Remove static initializer in url_info.cc.

Remove static initializer in url_info.cc.


BUG=94925
TEST=unit_tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125844

[battre, 2012-03-08 18:48:43]

http://codereview.chromium.org/9635018/diff/1/chrome/browser/net/url_info.cc
File chrome/browser/net/url_info.cc (right):

http://codereview.chromium.org/9635018/diff/1/chrome/browser/net/url_info.cc#...
chrome/browser/net/url_info.cc:57: static GlobalState* New(void* instance) {
Is this necessary? Could you not just use a constructor as in struct PathData of
base/path_service.cc for example and use LeakyLazyInstanceTraits?

I.e.

struct GlobalState {
  GlobalState() {
    cache_expiration_duration =
TimeDelta::FromSeconds(kDefaultCacheExpirationDuration);
  }
  TimeDelta cache_expiration_duration;
};

base::LazyInstance<GlobalState>::Leaky global_state = LAZY_INSTANCE_INITIALIZER;

[Philippe, 2012-03-09 08:48:09]

http://codereview.chromium.org/9635018/diff/1/chrome/browser/net/url_info.cc
File chrome/browser/net/url_info.cc (right):

http://codereview.chromium.org/9635018/diff/1/chrome/browser/net/url_info.cc#...
chrome/browser/net/url_info.cc:57: static GlobalState* New(void* instance) {
On 2012/03/08 18:48:43, battre wrote:
> Is this necessary? Could you not just use a constructor as in struct PathData
of
> base/path_service.cc for example and use LeakyLazyInstanceTraits?
> 
> I.e.
> 
> struct GlobalState {
>   GlobalState() {
>     cache_expiration_duration =
> TimeDelta::FromSeconds(kDefaultCacheExpirationDuration);
>   }
>   TimeDelta cache_expiration_duration;
> };
> 
> base::LazyInstance<GlobalState>::Leaky global_state =
LAZY_INSTANCE_INITIALIZER;

Indeed. I don't know how I managed to come up with such an unnecessarily
complicated thing :) I would have needed that if I only had the TimeDelta
without the struct.

[battre, 2012-03-09 08:56:14]

lgtm

http://codereview.chromium.org/9635018/diff/9001/chrome/browser/net/url_info.cc
File chrome/browser/net/url_info.cc (right):

http://codereview.chromium.org/9635018/diff/9001/chrome/browser/net/url_info....
chrome/browser/net/url_info.cc:199: const TimeDelta time_since_resolution =
TimeTicks::Now() - time_;
no need to make this const, but fine with me.

[Philippe, 2012-03-09 09:01:44]

Thanks for the quick review Dominic!

http://codereview.chromium.org/9635018/diff/9001/chrome/browser/net/url_info.cc
File chrome/browser/net/url_info.cc (right):

http://codereview.chromium.org/9635018/diff/9001/chrome/browser/net/url_info....
chrome/browser/net/url_info.cc:199: const TimeDelta time_since_resolution =
TimeTicks::Now() - time_;
On 2012/03/09 08:56:14, battre wrote:
> no need to make this const, but fine with me.

Done.

[commit-bot: I haz the power, 2012-03-09 09:02:12]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/9635018/10006

[commit-bot: I haz the power, 2012-03-09 11:55:24]

Try job failure for 9635018-10006 (retry) on win_rel for step "ui_tests".
It's a second try, previously, steps "browser_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2012-03-09 12:03:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pliard@chromium.org/9635018/10006

[commit-bot: I haz the power, 2012-03-09 14:39:50]

Change committed as 125844