Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 9630019: Make gles2_c_lib depend on command_buffer_client (Closed)

Created:
8 years, 9 months ago by Nico
Modified:
8 years, 9 months ago
CC:
chromium-reviews, apatrick_chromium
Visibility:
Public.

Description

Make gles2_c_lib depend on command_buffer_client gles2_c_lib is missing a dependency on command_buffer_client, since GLES2AttachShader and friends use gpu::CommandBufferHelper::GetSpace(unsigned int). This breaks the work-in-progress components build on mac. (Triggered by https://chromiumcodereview.appspot.com/9581018/) BUG=90078 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125691

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M gpu/gpu_common.gypi View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nico
8 years, 9 months ago (2012-03-08 19:17:20 UTC) #1
rvargas (doing something else)
lgtm
8 years, 9 months ago (2012-03-08 19:26:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9630019/1
8 years, 9 months ago (2012-03-08 19:34:56 UTC) #3
apatrick_chromium
lgtm
8 years, 9 months ago (2012-03-08 20:41:21 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-08 21:47:50 UTC) #5
Change committed as 125691

Powered by Google App Engine
This is Rietveld 408576698