Issue 9630019: Make gles2_c_lib depend on command_buffer_client

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9630019: Make gles2_c_lib depend on command_buffer_client (Closed)

Created:
8 years, 9 months ago by Nico

Modified:
8 years, 9 months ago

Reviewers:
rvargas (doing something else), apatrick_chromium

CC:
chromium-reviews, apatrick_chromium

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Make gles2_c_lib depend on command_buffer_client gles2_c_lib is missing a dependency on command_buffer_client, since GLES2AttachShader and friends use gpu::CommandBufferHelper::GetSpace(unsigned int). This breaks the work-in-progress components build on mac. (Triggered by https://chromiumcodereview.appspot.com/9581018/) BUG=90078 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125691

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -0 lines)			Patch
	M	gpu/gpu_common.gypi	View		2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 5 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/9630019/1

8 years, 9 months ago (2012-03-08 19:34:56 UTC) #3

Change committed as 125691