Error reporting on File in dart:io

runtime/bin/file.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 
 /**
  * FileMode describes the modes in which a file can be opened.
  */
 class FileMode {
   static final READ = const FileMode._internal(0);
@@ skipping 186 matching lines @@
 
   /**
    * Get the name of the file.
    */
   String get name();
 
   /**
    * Sets the handler that gets called when errors occur during
    * operations on this file.
    */
-  void set onError(void handler(String error));
+  void set onError(void handler(Exception e));
 }
 
 
 /**
  * [RandomAccessFile] provides random access to the data in a
  * file. [RandomAccessFile] objects are obtained by calling the
  * [:open:] method on a [File] object.
  */
 interface RandomAccessFile {
   /**
@@ skipping 141 matching lines @@
 
   /**
    * Sets the handler that gets called when errors occur when
    * operating on this file.
    */
   void set onError(void handler(String error));
 }
 
 
 class FileIOException implements Exception {
-  const FileIOException([String this.message = ""]);
-  String toString() => "FileIOException: $message";
+  const FileIOException([String this.message = "",
+                         OSError this.osError = null]);
+  String toString() {
+    StringBuffer sb = new StringBuffer();
+    sb.add("FileIOException");
+    if (message != null) {

[Mads Ager (google), 2012/03/13 10:56:17]

!message.isEmpty()?

[Søren Gjesse, 2012/03/13 12:39:49]

Done.

+      sb.add(": $message");
+      if (osError != null) {
+        sb.add(" (${osError.toString()})");

[Mads Ager (google), 2012/03/13 10:56:17]

You shouldn't have to explictly call toString here. String interpolation does
that for you.

[Søren Gjesse, 2012/03/13 12:39:49]

Done.

+      }
+    } else if (osError != null) {
+      sb.add(": ${osError.toString()}");

[Mads Ager (google), 2012/03/13 10:56:17]

Ditto.

[Søren Gjesse, 2012/03/13 12:39:49]

Done.

+    }
+    return sb.toString();
+  }
   final String message;
+  final OSError osError;
 }