Error reporting on File in dart:io

tests/standalone/src/io/FileTest.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 //
 // Dart test program for testing file I/O.
 
 #import("dart:io");
 #import("dart:isolate");
 
 class MyListOfOneElement implements List {
@@ skipping 492 matching lines @@
     Expect.isTrue(d.existsSync());
     Expect.isTrue(d.path.endsWith(tempDir));
     file.deleteSync();
     // Directories should throw exception.
     var file_dir = new File(".");
     Expect.throws(file_dir.directorySync, (e) { return e is FileIOException; });
     file_dir = new File(tempDir);
     Expect.throws(file_dir.directorySync, (e) { return e is FileIOException; });
   }
 
+  static void testFileError() {
+    void checkOpenNonExistentFileException(e) {
+      print(e);
+      Expect.isTrue(e is FileIOException);
+      Expect.isTrue(e.osError != null);
+      Expect.isTrue(e.toString().indexOf("Cannot open file") != -1);
+      if (new Platform().operatingSystem() == "macos") {

[Mads Ager (google), 2012/03/09 09:40:13]

Remember to broaden this one to the other platforms as well when implemented
there.

[Søren Gjesse, 2012/03/13 08:25:55]

Done.

+        Expect.isTrue(e.toString().indexOf("No such file or directory") != -1);
+        Expect.equals(2, e.osError.errorCode);
+      }
+    }
+
+    var tempDir = tempDirectory.path;
+    var file = new File("${tempDir}/nonExistentFile");
+
+    // Non-existing file should throw exception.
+    try {
+      file.openSync();
+    } catch (Exception e) {
+      checkOpenNonExistentFileException(e);
+    }
+
+    file.open(FileMode.READ, (raf) => Expect.fail("Unreachable code"));
+    file.onError = (e) => checkOpenNonExistentFileException(e);
+  }
+
+
   // Test for file length functionality.
   static void testLength() {
     String filename = getFilename("tests/vm/data/fixed_length_file");
     RandomAccessFile input = (new File(filename)).openSync();
     input.onError = (s) {
       Expect.fail("No errors expected");
     };
     input.length((length) {
       Expect.equals(42, length);
       input.close(() => null);
@@ skipping 510 matching lines @@
   // Helper method to be able to run the test from the runtime
   // directory, or the top directory.
   static String getFilename(String path) =>
       new File(path).existsSync() ? path : 'runtime/' + path;
 
   static String getDataFilename(String path) =>
       new File(path).existsSync() ? path : '../' + path;
 
   // Main test entrypoint.
   static testMain() {
-    testRead();
+    /*testRead();
     testReadSync();
     testReadStream();
     testLength();
     testLengthSync();
     testPosition();
     testPositionSync();
     testMixedSyncAndAsync();
     testOpenDirectoryAsFile();
     testOpenDirectoryAsFileSync();
     testReadAsBytes();
     testReadAsBytesSync();
     testReadAsText();
     testReadAsTextSync();
     testReadAsLines();
     testReadAsLinesSync();
     testReadAsErrors();
-
+*/
     createTempDirectory(() {
-      testReadWrite();
+/*      testReadWrite();
       testReadWriteSync();
       testReadWriteStream();
       testReadEmptyFileSync();
       testReadEmptyFile();
       testTruncate();
       testTruncateSync();
       testCloseException();
       testCloseExceptionStream();
       testBufferOutOfBoundsException();
       testAppend();
       testAppendSync();
       testWriteAppend();
       testOutputStreamWriteAppend();
       testWriteVariousLists();
       testDirectory();
-      testDirectorySync();
+      testDirectorySync();*/
+      testFileError();
     });
   }
 }
 
 main() {
   FileTest.testMain();
 }