Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9625029: Add a very simple example pepper plugin that uses a 3d context (Closed)

Created:
8 years, 9 months ago by jamesr
Modified:
8 years, 9 months ago
Reviewers:
brettw, piman
CC:
chromium-reviews, Ami GONE FROM CHROMIUM
Visibility:
Public.

Description

Add a very simple example pepper plugin that uses a 3d context This plugin (based off the gles2 demo before it got video stuff) instantiates a pepper 3d context and continually renders into it with glClear(). It also has very simple lost context recovery. BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=126011

Patch Set 1 #

Total comments: 2

Patch Set 2 : remove testdata.h from gypi #

Patch Set 3 : reinitialize context off of a timer instead of directly in the lost context callback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+201 lines, -0 lines) Patch
A ppapi/examples/gles2/gles2.cc View 1 2 1 chunk +168 lines, -0 lines 0 comments Download
A ppapi/examples/gles2/gles2.html View 1 chunk +18 lines, -0 lines 0 comments Download
M ppapi/ppapi_tests.gypi View 1 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jamesr
Antoine - can you check that I'm doing the Right Things for lost context here? ...
8 years, 9 months ago (2012-03-07 23:55:01 UTC) #1
Ami GONE FROM CHROMIUM
drive-by https://chromiumcodereview.appspot.com/9625029/diff/1/ppapi/ppapi_tests.gypi File ppapi/ppapi_tests.gypi (right): https://chromiumcodereview.appspot.com/9625029/diff/1/ppapi/ppapi_tests.gypi#newcode381 ppapi/ppapi_tests.gypi:381: 'examples/gles2/testdata.h', Drop this?
8 years, 9 months ago (2012-03-07 23:59:38 UTC) #2
piman
lgtm https://chromiumcodereview.appspot.com/9625029/diff/1/ppapi/examples/gles2/gles2.cc File ppapi/examples/gles2/gles2.cc (right): https://chromiumcodereview.appspot.com/9625029/diff/1/ppapi/examples/gles2/gles2.cc#newcode48 ppapi/examples/gles2/gles2.cc:48: // or try to revive it somehow? The ...
8 years, 9 months ago (2012-03-08 00:03:44 UTC) #3
piman
On Wed, Mar 7, 2012 at 4:21 PM, <jamesr@chromium.org> wrote: > Recreating in the SwapBuffers ...
8 years, 9 months ago (2012-03-08 00:41:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9625029/12001
8 years, 9 months ago (2012-03-09 21:16:37 UTC) #5
commit-bot: I haz the power
Presubmit check for 9625029-12001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 9 months ago (2012-03-09 21:16:41 UTC) #6
brettw
LGTM
8 years, 9 months ago (2012-03-09 21:18:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9625029/12001
8 years, 9 months ago (2012-03-09 21:19:16 UTC) #8
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary filesare still unsupported at ...
8 years, 9 months ago (2012-03-09 23:58:44 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9625029/12001
8 years, 9 months ago (2012-03-10 00:00:53 UTC) #10
commit-bot: I haz the power
Try job failure for 9625029-12001 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 9 months ago (2012-03-10 03:07:10 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/9625029/12001
8 years, 9 months ago (2012-03-10 03:09:47 UTC) #12
commit-bot: I haz the power
8 years, 9 months ago (2012-03-10 06:25:31 UTC) #13 
Change committed as 126011

Powered by Google App Engine
This is Rietveld 408576698