Save password without an associated username.

webkit/forms/password_form_dom_manager.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/forms/password_form_dom_manager.h"
 
 #include "base/logging.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebInputElement.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebPasswordFormData.h"
 #include "webkit/forms/form_field.h"
@@ skipping 19 matching lines @@
   return NULL;
 }
 
 // static
 void PasswordFormDomManager::InitFillData(
     const PasswordForm& form_on_page,
     const PasswordFormMap& matches,
     const PasswordForm* const preferred_match,
     bool wait_for_username_before_autofill,
     PasswordFormFillData* result) {
-  // Note that many of the |FormField| members are not initialized for
-  // |username_field| and |password_field| because they are currently not used
-  // by the password autocomplete code.
-  FormField username_field;
-  username_field.name = form_on_page.username_element;
-  username_field.value = preferred_match->username_value;
-  FormField password_field;
-  password_field.name = form_on_page.password_element;
-  password_field.value = preferred_match->password_value;
 
   // Fill basic form data.
   result->basic_data.origin = form_on_page.origin;
   result->basic_data.action = form_on_page.action;
-  result->basic_data.fields.push_back(username_field);
+  result->wait_for_username = wait_for_username_before_autofill;
+
+  // Note that many of the |FormField| members are not initialized for
+  // |username_field| and |password_field| because they are currently not used
+  // by the password autocomplete code.
+  FormField password_field;
+  password_field.name = form_on_page.password_element;
+  password_field.value = preferred_match->password_value;
   result->basic_data.fields.push_back(password_field);
-  result->wait_for_username = wait_for_username_before_autofill;
+
+  // If username_element is empty string,
+  // we suppose that there isn't any username field and don't set the username.

[Ilya Sherman, 2012/04/19 00:27:37]

nit: Please wrap to 80-col, so that the first line is not shorter than the
second one.  For the wording, perhaps "The |username_element| should be empty if
and only if the form does not include a username field."

+  if (!form_on_page.username_element.empty()) {
+    FormField username_field;
+    username_field.name = form_on_page.username_element;
+    username_field.value = preferred_match->username_value;
+    result->basic_data.fields.push_back(username_field);
+  }
 
   // Copy additional username/value pairs.
   PasswordFormMap::const_iterator iter;
   for (iter = matches.begin(); iter != matches.end(); iter++) {
     if (iter->second != preferred_match)
       result->additional_logins[iter->first] = iter->second->password_value;
   }
 }
 
 }  // namespace forms
 }  // namespace webkit