Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(553)

Issue 9625022: Use cmd.exe instead of python.exe for unit test. (Closed)

Created:
8 years, 9 months ago by M-A Ruel
Modified:
8 years, 9 months ago
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

Use cmd.exe instead of python.exe for unit test. This removes the last dependency on src/third_party/python_26 from base_unittests.exe. Windows-only change. R=jar@chromium.org BUG=116206 TEST=base_unittests still pass Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125506

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -14 lines) Patch
M base/process_util_unittest.cc View 1 chunk +13 lines, -14 lines 1 comment Download

Messages

Total messages: 5 (0 generated)
M-A Ruel
8 years, 9 months ago (2012-03-07 21:26:23 UTC) #1
jar (doing other things)
https://chromiumcodereview.appspot.com/9625022/diff/1/base/process_util_unittest.cc File base/process_util_unittest.cc (right): https://chromiumcodereview.appspot.com/9625022/diff/1/base/process_util_unittest.cc#newcode433 base/process_util_unittest.cc:433: cmd_line.AppendArg("echo " + message + " >&2"); Although a ...
8 years, 9 months ago (2012-03-07 22:05:35 UTC) #2
jar (doing other things)
lgtm
8 years, 9 months ago (2012-03-07 22:09:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9625022/1
8 years, 9 months ago (2012-03-07 22:10:00 UTC) #4
commit-bot: I haz the power
8 years, 9 months ago (2012-03-08 00:01:38 UTC) #5
Change committed as 125506

Powered by Google App Engine
This is Rietveld 408576698