Ported NTP4 UI tests to WebUI.

chrome/test/data/webui/ntp4.js

-// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Copyright (c) 2012 The Chromium Authors.  All rights reserved.

[Dan Beam, 2012/03/15 00:12:55]

nit: we don't use 2 spaces, only 1 between sentences

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+GEN('#include "chrome/test/data/webui/ntp4_browsertest.h"');
+
 /**
  * TestFixture for NTP4 WebUI testing.
  * @extends {testing.Test}
  * @constructor
  */
 function NTP4WebUITest() {}
 
 NTP4WebUITest.prototype = {
   __proto__: testing.Test.prototype,
 
-  /**
-   * Browse to the newtab page & call preLoad().
-   */
+  /** @override */
   browsePreload: 'chrome://newtab',
 };
 
 // Test loading new tab page and selecting each card doesn't have console
 // errors.
 TEST_F('NTP4WebUITest', 'TestBrowsePages', function() {
-// This tests the ntp4 new tab page which is not used on touch builds.
+  // This tests the ntp4 new tab page which is not used on touch builds.
   var cardSlider = ntp.getCardSlider();
   assertNotEquals(null, cardSlider);
-  for (var i = 0; i < cardSlider.cardCount; ++i) {
+  for (var i = 0; i < cardSlider.cardCount; i++) {
     cardSlider.selectCard(i);
     expectEquals(i, cardSlider.currentCard);
   }
 });
+
+TEST_F('NTP4WebUITest', 'NTPHasThumbnails', function() {
+  var mostVisited = document.querySelectorAll('.most-visited');
+  assertEquals(8, mostVisited.length, 'There should be 8 most visited tiles.');
+
+  var apps = document.querySelectorAll('.app');
+  if (window.templateData.showApps) {

[Dan Beam, 2012/03/15 00:12:55]

nit: no curlies when both conditional and body of conditional (and all follow up
conditionals) are 1 line. Ex:

  if (blah)
    blee();
  else if (blar)
    blag();
  else
    blug();

[Danh Nguyen, 2012/03/15 15:42:09]

Done.

+    assertGE(apps.length, 1, 'There should be at least one app.');
+  }
+  else {

[Dan Beam, 2012/03/15 00:12:55]

nit: if you do need curlies, we "cuddle" them, i.e.

  if (cond) {
    // stuff here
  } else if (cond) {
    // more here
  } else {
    // some stuff
    // down here
  }

[Danh Nguyen, 2012/03/15 15:42:09]

Done.

+    assertGE(apps.length, 0, 'There should be no app.');

[Dan Beam, 2012/03/15 00:12:55]

nit: no apps.

[Danh Nguyen, 2012/03/15 15:42:09]

Done.

+  }
+});
+
+TEST_F('NTP4WebUITest', 'NTPHasNavDots', function() {
+  var navDots = document.querySelectorAll('.dot');
+  if (window.templateData.showApps) {
+    assertGE(navDots.length, 2, 'There should be at least two navdots.');
+  }
+  else {
+    assertGE(navDots.length, 0, 'There should be no navdot.');

[Dan Beam, 2012/03/15 00:12:55]

nit: no navdots.

[Dan Beam, 2012/03/15 00:13:27]

whoops, sorry, this should be assertEquals()

[Danh Nguyen, 2012/03/15 15:42:09]

Fixed.

[Danh Nguyen, 2012/03/15 15:42:09]

Actually on ChromeOS in the browser tests' settings, there is only one navDot. 
So I changed this into:
assertEquals(1, navDots.length, 'There should be only one navdot.')

Thanks Dan for catching this.

+  }
+});
+
+TEST_F('NTP4WebUITest', 'NTPHasSelectedPageAndDot', function() {

[Dan Beam, 2012/03/15 00:15:25]

and this should also be wrapped with showApps as navdots don't show, you can
build chrome as ChromeOS with

  ./build/gyp_chromium -Dchromeos=1 # until you rerun this or gclient runhooks
or
  export GYP_DEFINES="$GYP_DEFINES chromeos=1" && gclient runhooks
and recompile and run tests

[Danh Nguyen, 2012/03/15 15:42:09]

On ChromeOS there is only one navdot and it's selected, although it's not
visible.  So this test still applies.

Thanks for the tips of building Chrome as ChromeOS.  I have been doing similar
thing except that I have to add:
 { "name": "cros_deps",
    "url": http://src.chromium.org/svn/trunk/src/tools/cros.DEPS",
 },
into my .gclient file (before running gclient sync), and didn't run 'gclient
runhooks'.  Does 'gclient runhooks' do that for us?

+  var selectedDot = document.querySelectorAll('.dot.selected');
+  assertEquals(1, selectedDot.length, 'There should be only one selected dot.');
+
+  var selectedTilePage = document.querySelectorAll('.tile-page.selected-card');
+  assertEquals(1, selectedTilePage.length,
+               'There should be only one selected tile page.');
+});
+
+TEST_F('NTP4WebUITest', 'NTPHasNoLoginNameWhenSignedOut', function() {
+  var userName = document.querySelector('#login-status-header .profile-name');
+  assertEquals(null, userName, 'Login name shouldn\'t exist when signed out.');
+});
+
+/**
+ * Test fixture for NTP4 WebUI testing with login.
+ * @extends {NTP4WebUITest}
+ * @constructor
+ */
+function NTP4LoggedInWebUITest() {}
+
+NTP4LoggedInWebUITest.prototype = {
+  __proto__: NTP4WebUITest.prototype,
+
+  /** @override */
+  typedefCppFixture: 'NTP4LoggedInWebUITest',
+
+  /** @override */
+  testGenPreamble: function() {
+    GEN('  SetLoginName("user@gmail.com");');
+  },
+};
+
+// The following test is irrelevant to Chrome on Chrome OS.
+GEN('#if !defined(OS_CHROMEOS)');
+
+TEST_F('NTP4LoggedInWebUITest', 'NTPHasLoginNameWhenSignedIn', function() {
+  var userName = document.querySelector('#login-status-header .profile-name');
+  assertNotEquals(userName, null, 'The logged-in user name can\'t be found.');
+  assertEquals('user@gmail.com', userName.textContent,
+               'The user name should be present on the new tab.');
+});
+
+GEN('#endif');