Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 9625006: Implement new overlay style for options pages. (Closed)

Created:
8 years, 9 months ago by flackr
Modified:
8 years, 9 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews, tfarina, arv (Not doing code reviews)
Visibility:
Public.

Description

Implement new overlay style for options pages. I've attached screenshots in the bug. The changes covered in this CL are: - background radial gradient. - dialog panel animation when clicking on modally blocked area. - text color - title font size. - x close button visuals and placement. - size and placement of action buttons. - dialog internal padding. - border radius - drop shadow BUG=116312 TEST=Test the new dialogs on the options page. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=126414

Patch Set 1 #

Patch Set 2 : Style fix. #

Patch Set 3 : Add binary resources. #

Patch Set 4 : Merge with master. #

Patch Set 5 : Restore white background on overlays. #

Patch Set 6 : Merge with master. #

Total comments: 2

Patch Set 7 : Use c++ style comment. #

Patch Set 8 : Remove binaries. #

Patch Set 9 : Merge with master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -36 lines) Patch
M chrome/browser/resources/options2/alert_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/autofill_edit_address_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/autofill_edit_creditcard_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/autofill_options.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/certificate_backup_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/certificate_edit_ca_trust_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/certificate_import_error_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/certificate_manager.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/certificate_restore_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/accounts_options.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/bluetooth_add_device_overlay.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/bluetooth_pair_device_overlay.html View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/change_picture_options.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/internet_detail.html View 1 2 3 4 5 6 7 8 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/internet_options.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/keyboard_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/language_chewing_options.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/language_hangul_options.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/language_mozc_options.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/language_pinyin_options.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/pointer_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/preferred_networks.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/proxy.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/virtual_keyboard.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/clear_browser_data_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/content_settings.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/content_settings_exceptions_area.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/cookies_view.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/font_settings.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/handler_options.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/home_page_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/import_data_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/instant_confirm_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/language_add_language_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/language_options.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/manage_profile_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/options_page.css View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/resources/options2/password_manager.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/search_engine_manager.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/session_restore_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options2/startup_overlay.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/shared/css/overlay.css View 1 2 3 4 5 6 7 8 2 chunks +45 lines, -23 lines 0 comments Download
M chrome/browser/resources/shared/js/cr/ui/overlay.js View 1 2 3 4 5 6 2 chunks +13 lines, -5 lines 0 comments Download
M chrome/browser/resources/shared_resources.grd View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.html View 3 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
flackr
Hi James, I'm updating the style of overlays on the options page as described in ...
8 years, 9 months ago (2012-03-07 17:53:40 UTC) #1
James Hawkins
Can you attach before and after screenshots?
8 years, 9 months ago (2012-03-08 17:20:46 UTC) #2
flackr
On 2012/03/08 17:20:46, James Hawkins wrote: > Can you attach before and after screenshots? Posted ...
8 years, 9 months ago (2012-03-12 20:15:49 UTC) #3
James Hawkins
LGTM with nit. http://codereview.chromium.org/9625006/diff/15001/chrome/browser/resources/shared/js/cr/ui/overlay.js File chrome/browser/resources/shared/js/cr/ui/overlay.js (right): http://codereview.chromium.org/9625006/diff/15001/chrome/browser/resources/shared/js/cr/ui/overlay.js#newcode54 chrome/browser/resources/shared/js/cr/ui/overlay.js:54: /* Close the overlay on clicking ...
8 years, 9 months ago (2012-03-12 20:26:01 UTC) #4
flackr
Going to commit the binaries separately so I can use the CQ for this. Thanks! ...
8 years, 9 months ago (2012-03-12 20:32:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/9625006/9009
8 years, 9 months ago (2012-03-12 20:39:08 UTC) #6
commit-bot: I haz the power
Try job failure for 9625006-9009 (retry) (retry) (retry) on linux_rel for step "check_deps". It's a ...
8 years, 9 months ago (2012-03-12 22:05:30 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/9625006/18003
8 years, 9 months ago (2012-03-13 14:32:35 UTC) #8
commit-bot: I haz the power
8 years, 9 months ago (2012-03-13 17:15:16 UTC) #9
Try job failure for 9625006-18003 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698