Prerendered pages are swapped in at browser::Navigate time.

Prerendered pages are swapped in at browser::Navigate time. 

They used to get swapped in by observing provisional loads. This is being changed to Navigate so renderer-issued navigations into a prerender can be handled with the same mechanism that is used to handle renderer-issued navigations which need to cross process boundaries, such as clicking into a hosted app. 

For browser issued navigations, this means that we will immediately swap in the prerender, instead of sending a Navigate message to the render view and swapping in on the provisional load statement. 

For renderer issued navigations, decidePolicyForNavigation will ultimately cancel the navigation in the renderer and send an OpenURL up to the browser process. 

In order to make the renderer know that a navigation could be prerendered, a set of prerendered URLs need to be sent to a render process. 

BUG=104493
TEST=Existing browser tests, manual tests that omnibox prerenders work. There should be no user-visible changes.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125836

[cbentzel, 2012-03-07 22:30:46]

John - this is exactly http://codereview.chromium.org/9416031/

But that got hit by a rietveld bug - see
https://groups.google.com/a/chromium.org/group/chromium-dev/browse_thread/thr...

That CL was LGTM'ed by everyone, and I'm only pinging you again since you have
OWNERS permission for some of the directories that I do not.

[jam, 2012-03-07 22:50:15]

lgtm

[commit-bot: I haz the power, 2012-03-08 12:28:15]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cbentzel@chromium.org/9623018/1

[commit-bot: I haz the power, 2012-03-08 12:28:44]

Presubmit check for 9623018-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/ui/webui/net_internals/net_internals_ui_browsertest.cc,chrome/browser/ui/browser_navigator.cc

Presubmit checks took 9.1s to calculate.

[mmenke, 2012-03-08 12:29:40]

net_internals still LGTM.

[cbentzel, 2012-03-08 12:30:00]

Matt, also need OWNERS approval for net_internals.

Same CL as before, just with a fixed rietveld issue.

[commit-bot: I haz the power, 2012-03-08 12:32:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cbentzel@chromium.org/9623018/1

[commit-bot: I haz the power, 2012-03-08 12:32:34]

Presubmit check for 9623018-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit ERRORS **
Missing LGTM from an OWNER for: chrome/browser/ui/browser_navigator.cc

Presubmit checks took 2.4s to calculate.

[cbentzel, 2012-03-08 12:50:04]

+pkasting for browser_navigator.cc change.

Peter - this was previously approved by creis and you can see more of the review
comments at http://codereview.chromium.org/9416031/

Had to move to a separate issue due to rietveld problems.

[Peter Kasting, 2012-03-08 20:56:38]

If creis is fine with it I am.  LGTM

http://codereview.chromium.org/9623018/diff/1/chrome/browser/ui/browser_navig...
File chrome/browser/ui/browser_navigator.cc (right):

http://codereview.chromium.org/9623018/diff/1/chrome/browser/ui/browser_navig...
chrome/browser/ui/browser_navigator.cc:372: if (!prerender_manager)
Nit: Shorter:

  return prerender_manager && prerender_manager->MaybeUsePrerenderedPage(
      target_contents->web_contents(), url);

[commit-bot: I haz the power, 2012-03-09 10:41:50]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/cbentzel@chromium.org/9623018/1

[commit-bot: I haz the power, 2012-03-09 14:06:52]

Change committed as 125836