Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 9621007: Add new danger type for uncommon or unknown downloads. (Closed)

Created:
8 years, 9 months ago by asanka
Modified:
8 years, 9 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, jam, achuith+watch_chromium.org, mihaip+watch_chromium.org, Randy Smith (Not in Mondays), joi+watch-content_chromium.org, arv (Not doing code reviews), darin-cc_chromium.org, rdsmith+dwatch_chromium.org
Visibility:
Public.

Description

Add new danger type for uncommon or unknown downloads. BUG=102540 TEST=Downloading a binary that is marked by the safe browsing service as uncommon should show the uncommon download warning. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=127093

Patch Set 1 #

Patch Set 2 : Rebase #

Total comments: 2

Patch Set 3 : Update experimental.downloads.json #

Patch Set 4 : Rebased only #

Total comments: 1

Patch Set 5 : Rebase #

Patch Set 6 : Rebased #

Patch Set 7 : " #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -11 lines) Patch
M chrome/browser/download/download_extension_api.cc View 1 2 3 4 5 6 3 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/download/download_item_model.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M chrome/browser/download/download_util.cc View 1 2 3 4 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/resources/chromeos/active_downloads.js View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/downloads/downloads.js View 1 2 3 4 2 chunks +6 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/active_downloads_ui.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/downloads_ui.cc View 1 2 3 4 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/extensions/api/experimental.downloads.json View 1 2 3 4 5 4 chunks +13 lines, -4 lines 0 comments Download
M content/browser/download/download_net_log_parameters.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/download/download_state_info.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/public/browser/download_danger_type.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (0 generated)
asanka
This is the first cut integrating the uncommon download warning into the UI. I tested ...
8 years, 9 months ago (2012-03-07 21:03:26 UTC) #1
mattm
thanks, lgtm from my end
8 years, 9 months ago (2012-03-07 22:10:23 UTC) #2
noelutz
lgtm Sweet! noé. http://codereview.chromium.org/9621007/diff/2001/content/public/browser/download_danger_type.h File content/public/browser/download_danger_type.h (right): http://codereview.chromium.org/9621007/diff/2001/content/public/browser/download_danger_type.h#newcode34 content/public/browser/download_danger_type.h:34: DOWNLOAD_DANGER_TYPE_UNCOMMON_CONTENT, Can you confirm that this ...
8 years, 9 months ago (2012-03-08 16:05:42 UTC) #3
asanka
I know some of you have already looked through the CL, but here's an explicit ...
8 years, 9 months ago (2012-03-08 16:29:56 UTC) #4
benjhayden
Please update chrome/common/extensions/api/experimental.downloads.json both in the properties section, DownloadItem.danger.enum, and DownloadQuery.danger.enum. Looks like DownloadQuery.danger.enum is ...
8 years, 9 months ago (2012-03-08 16:30:48 UTC) #5
benjhayden
On 2012/03/08 16:29:56, asanka wrote: > I know some of you have already looked through ...
8 years, 9 months ago (2012-03-08 16:32:02 UTC) #6
Randy Smith (Not in Mondays)
LGTM; thanks!
8 years, 9 months ago (2012-03-08 17:03:02 UTC) #7
asanka
On 2012/03/08 16:30:48, benjhayden_chromium wrote: > Please update chrome/common/extensions/api/experimental.downloads.json both in > the properties section, ...
8 years, 9 months ago (2012-03-08 17:49:34 UTC) #8
benjhayden
On 2012/03/08 17:49:34, asanka wrote: > On 2012/03/08 16:30:48, benjhayden_chromium wrote: > > Please update ...
8 years, 9 months ago (2012-03-08 19:12:27 UTC) #9
asanka
Adding OWNERS :) estade: chrome/browser/resources/* chrome/browser/ui/webui/* aa: chrome/common/extensions/api/* Thanks!
8 years, 9 months ago (2012-03-08 19:54:43 UTC) #10
achuithb
lgtm
8 years, 9 months ago (2012-03-08 20:35:04 UTC) #11
ahendrickson
LGTM
8 years, 9 months ago (2012-03-08 23:47:36 UTC) #12
asanka
Thanks! Evan, Aaaron: Ping?
8 years, 9 months ago (2012-03-09 15:58:44 UTC) #13
Evan Stade
http://codereview.chromium.org/9621007/diff/15001/chrome/browser/ui/webui/active_downloads_ui.cc File chrome/browser/ui/webui/active_downloads_ui.cc (right): http://codereview.chromium.org/9621007/diff/15001/chrome/browser/ui/webui/active_downloads_ui.cc#newcode5 chrome/browser/ui/webui/active_downloads_ui.cc:5: #include "chrome/browser/ui/webui/active_downloads_ui.h" please move these files to ui/webui/chromeos/
8 years, 9 months ago (2012-03-09 22:41:45 UTC) #14
asanka
On 2012/03/09 22:41:45, Evan Stade wrote: > http://codereview.chromium.org/9621007/diff/15001/chrome/browser/ui/webui/active_downloads_ui.cc > File chrome/browser/ui/webui/active_downloads_ui.cc (right): > > http://codereview.chromium.org/9621007/diff/15001/chrome/browser/ui/webui/active_downloads_ui.cc#newcode5 ...
8 years, 9 months ago (2012-03-10 02:11:14 UTC) #15
benjhayden
FYI https://chromiumcodereview.appspot.com/9689007 downloads.js may move out from under you.
8 years, 9 months ago (2012-03-12 14:14:23 UTC) #16
Aaron Boodman
extensions lgtm
8 years, 9 months ago (2012-03-12 20:09:26 UTC) #17
asanka
Evan: Can you take another look? I moved the active_downloads_ui* to a chromeos/ subdirectory.
8 years, 9 months ago (2012-03-14 15:43:05 UTC) #18
Evan Stade
lgtm
8 years, 9 months ago (2012-03-14 21:34:52 UTC) #19
Evan Stade
lgtm
8 years, 9 months ago (2012-03-14 21:34:52 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/9621007/25001
8 years, 9 months ago (2012-03-15 01:42:02 UTC) #21
commit-bot: I haz the power
Try job failure for 9621007-25001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-15 04:26:54 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/9621007/25001
8 years, 9 months ago (2012-03-15 05:18:37 UTC) #23
commit-bot: I haz the power
Try job failure for 9621007-25001 (retry) on win for step "compile" (clobber build). It's a ...
8 years, 9 months ago (2012-03-15 06:34:41 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asanka@chromium.org/9621007/25001
8 years, 9 months ago (2012-03-15 15:14:16 UTC) #25
commit-bot: I haz the power
8 years, 9 months ago (2012-03-15 18:20:52 UTC) #26
Try job failure for 9621007-25001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

Powered by Google App Engine
This is Rietveld 408576698