Added Protector backup for Preferences.

chrome/browser/protector/protected_prefs_watcher_unittest.cc

Index: chrome/browser/protector/protected_prefs_watcher_unittest.cc
diff --git a/chrome/browser/protector/protected_prefs_watcher_unittest.cc b/chrome/browser/protector/protected_prefs_watcher_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b1ec3aeadc2011a632ed358dc9d9ea3b35fe06d8
--- /dev/null
+++ b/chrome/browser/protector/protected_prefs_watcher_unittest.cc
@@ -0,0 +1,141 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/message_loop.h"
+#include "base/values.h"
+#include "chrome/browser/extensions/extension_pref_value_map.h"
+#include "chrome/browser/extensions/extension_prefs.h"
+#include "chrome/browser/extensions/extension_service.h"
+#include "chrome/browser/prefs/pref_service.h"
+#include "chrome/browser/protector/protected_prefs_watcher.h"
+#include "chrome/browser/protector/protector_service.h"
+#include "chrome/browser/protector/protector_service_factory.h"
+#include "chrome/common/extensions/extension_constants.h"
+#include "chrome/common/pref_names.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/test/test_browser_thread.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace protector {
+
+namespace {
+
+const char kNewHomePage[] = "http://example.com";
+
+}
+
+class ProtectedPrefsWatcherTest : public testing::Test {
+ public:
+  virtual void SetUp() OVERRIDE {
+    prefs_watcher_ =
+        ProtectorServiceFactory::GetForProfile(&profile_)->GetPrefsWatcher();
+    prefs_ = profile_.GetPrefs();
+  }
+
+  bool IsSignatureValid() {
+    return prefs_watcher_->IsSignatureValid();
+  }
+
+  bool HasBackup() {
+    return prefs_watcher_->HasBackup();
+  }
+
+  void RevalidateBackup() {
+    prefs_watcher_->ValidateBackup();
+  }
+
+ protected:
+  ProtectedPrefsWatcher* prefs_watcher_;
+  TestingProfile profile_;
+  PrefService* prefs_;
+};
+
+TEST_F(ProtectedPrefsWatcherTest, ValidOnCleanProfile) {
+  EXPECT_TRUE(HasBackup());
+  EXPECT_TRUE(IsSignatureValid());
+  EXPECT_TRUE(prefs_watcher_->is_backup_valid());
+}
+
+TEST_F(ProtectedPrefsWatcherTest, ValidAfterPrefChange) {
+  // Signature is still valid after a protected pref has been changed.
+  base::StringValue new_homepage(kNewHomePage);
+  EXPECT_NE(prefs_->GetString(prefs::kHomePage), kNewHomePage);
+  EXPECT_FALSE(new_homepage.Equals(
+      prefs_watcher_->GetBackupForPref(prefs::kHomePage)));
+
+  prefs_->SetString(prefs::kHomePage, kNewHomePage);
+
+  EXPECT_TRUE(HasBackup());
+  EXPECT_TRUE(IsSignatureValid());
+  EXPECT_TRUE(prefs_watcher_->is_backup_valid());
+  EXPECT_EQ(prefs_->GetString(prefs::kHomePage), kNewHomePage);
+  // Backup is updated accordingly.
+  EXPECT_TRUE(new_homepage.Equals(
+      prefs_watcher_->GetBackupForPref(prefs::kHomePage)));
+}
+
+TEST_F(ProtectedPrefsWatcherTest, InvalidSignature) {
+  // Make backup invalid by changing one of its members directly.
+  prefs_->SetString("backup.homepage", kNewHomePage);
+  RevalidateBackup();
+  EXPECT_TRUE(HasBackup());
+  EXPECT_FALSE(IsSignatureValid());
+  EXPECT_FALSE(prefs_watcher_->is_backup_valid());
+  // No backup values available.
+  EXPECT_FALSE(prefs_watcher_->GetBackupForPref(prefs::kHomePage));
+
+  // Now change the corresponding protected prefernce: backup should be signed
+  // again but still invalid.
+  prefs_->SetString(prefs::kHomePage, kNewHomePage);
+  EXPECT_TRUE(IsSignatureValid());
+  EXPECT_FALSE(prefs_watcher_->is_backup_valid());
+  EXPECT_FALSE(prefs_watcher_->GetBackupForPref(prefs::kHomePage));
+}
+
+TEST_F(ProtectedPrefsWatcherTest, ExtensionPrefChange) {
+  // Changes to extensions data (but not to extension IDs) do not update
+  // the backup and its signature.
+  MessageLoopForUI message_loop;
+  content::TestBrowserThread ui_thread(content::BrowserThread::UI,
+                                       &message_loop);
+
+  FilePath extensions_install_dir =
+      profile_.GetPath().AppendASCII(ExtensionService::kInstallDirectoryName);
+  scoped_ptr<ExtensionPrefValueMap> extension_pref_value_map_(
+      new ExtensionPrefValueMap);
+  scoped_ptr<ExtensionPrefs> extension_prefs(
+      new ExtensionPrefs(profile_.GetPrefs(),
+                         extensions_install_dir,
+                         extension_pref_value_map_.get()));
+  std::string sample_id = extension_misc::kWebStoreAppId;
+  extension_prefs->Init(false);
+  // Flip a pref value of an extension (this will actually add it to the list).
+  extension_prefs->SetAppNotificationDisabled(
+      sample_id, !extension_prefs->IsAppNotificationDisabled(sample_id));
+
+  // Backup is still valid.
+  EXPECT_TRUE(IsSignatureValid());
+  EXPECT_TRUE(prefs_watcher_->is_backup_valid());
+
+  // Make backup invalid by changing one of its members directly.
+  prefs_->SetString("backup.homepage", kNewHomePage);
+  RevalidateBackup();
+  EXPECT_FALSE(IsSignatureValid());
+
+  // Flip another pref value of that extension.
+  extension_prefs->SetIsIncognitoEnabled(
+      sample_id, !extension_prefs->IsIncognitoEnabled(sample_id));
+
+  // No changes to the backup and signature.
+  EXPECT_FALSE(IsSignatureValid());
+
+  // Blacklisting the extension does update the backup and signature.
+  std::set<std::string> blacklist;
+  blacklist.insert(sample_id);
+  extension_prefs->UpdateBlacklist(blacklist);
+
+  EXPECT_TRUE(IsSignatureValid());
+}
+
+}  // namespace protector