Added Protector backup for Preferences.

chrome/browser/protector/protected_prefs_watcher.h

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_PROTECTOR_PROTECTED_PREFS_WATCHER_H_
+#define CHROME_BROWSER_PROTECTOR_PROTECTED_PREFS_WATCHER_H_
+#pragma once
+
+#include <set>
+#include <string>
+
+#include "base/basictypes.h"
+#include "base/memory/scoped_ptr.h"
+#include "content/public/browser/notification_observer.h"
+
+class PrefService;
+class PrefSetObserver;
+class Profile;
+
+namespace protector {
+
+class ProtectedPrefsWatcher : public content::NotificationObserver {
+ public:
+  explicit ProtectedPrefsWatcher(Profile* profile);
+  ~ProtectedPrefsWatcher();
+
+  // Registers prefs on a new Profile instance.
+  static void RegisterUserPrefs(PrefService* prefs);
+
+  // Perform a check that backup is valid and settings have not been modified.
+  void CheckForPrefChanges();

[whywhat, 2012/03/07 18:53:30]

nit: Maybe ValidateProtectedPrefs or something like this?
write a comment what happens if the backup is invalid, what's the post effect of
this method?

[Ivan Korotkov, 2012/03/11 12:59:44]

I didn't document the behaviour for now because it's a stub and subject to
change.

+
+ private:
+  // content::NotificationObserver overrides:
+  virtual void Observe(int type,
+                       const content::NotificationSource& source,
+                       const content::NotificationDetails& details) OVERRIDE;
+
+  // Updates cached prefs from their actual values and returns |true| if there
+  // were any changes.
+  bool UpdateCachedPrefs();
+
+  // Update the backup signature.
+  void UpdateBackupSignature();
+
+  // Checks if backup signature is valid.
+  bool IsSignatureValid();

[whywhat, 2012/03/07 18:53:30]

const?

[Ivan Korotkov, 2012/03/11 12:59:44]

Done.

+
+  // Returns |false| if |profile_| does not have a backup yet (needs to be
+  // initialized).
+  bool HasBackup();

[whywhat, 2012/03/07 18:53:30]

const?

[Ivan Korotkov, 2012/03/11 12:59:44]

Done.

+
+  // Returns data to be signed as string.
+  std::string GetSignatureData(PrefService* prefs);

[whywhat, 2012/03/07 18:53:30]

ditto

[Ivan Korotkov, 2012/03/11 12:59:44]

Done.

+
+  // Cached set of extension IDs. They are not changed as frequently
+  std::set<std::string> cached_extension_ids_;
+
+  scoped_ptr<PrefSetObserver> pref_observer_;
+
+  bool did_startup_settings_change_;

[whywhat, 2012/03/07 18:53:30]

Comment about this member?

[Ivan Korotkov, 2012/03/11 12:59:44]

Stale member, forgot to remove.

+
+  Profile* profile_;
+
+  DISALLOW_COPY_AND_ASSIGN(ProtectedPrefsWatcher);
+};
+
+}  // namespace protector
+
+#endif  // CHROME_BROWSER_PROTECTOR_PROTECTED_PREFS_WATCHER_H_