WebSocket Pepper API: Implement extensions

WebSocket Pepper API: Implement extensions

BUG=87310
TEST=ui_tests --gtest_filter="*WebSocket*"


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125962

[Takashi Toyoshima, 2012-03-07 21:09:35]

Hi David,

Now WebSocket implementation in WebKit supports the extensions property.
I'd like to implement the property also in Pepper API.

Could you review this CL?

Thanks,

[dmichael (off chromium), 2012-03-09 18:27:16]

http://codereview.chromium.org/9619021/diff/1005/ppapi/tests/test_websocket.cc
File ppapi/tests/test_websocket.cc (right):

http://codereview.chromium.org/9619021/diff/1005/ppapi/tests/test_websocket.c...
ppapi/tests/test_websocket.cc:752: "x-webkit-deflate-frame"));
What's the extension do? Is there a way for a PPAPI user to use the extension?

[Takashi Toyoshima, 2012-03-09 18:46:15]

Thanks.

http://codereview.chromium.org/9619021/diff/1005/ppapi/tests/test_websocket.cc
File ppapi/tests/test_websocket.cc (right):

http://codereview.chromium.org/9619021/diff/1005/ppapi/tests/test_websocket.c...
ppapi/tests/test_websocket.cc:30:
"ws://localhost:8880/websocket/tests/hybi/echo";
This URL will be changed to ".../hybi/echo-with-no-extension".

http://codereview.chromium.org/9619021/diff/1005/ppapi/tests/test_websocket.c...
ppapi/tests/test_websocket.cc:752: "x-webkit-deflate-frame"));
Extensions is defined in RFC for WebSocket.
This mechanism is used to extend base WebSocket protocol, E.g., adding zlib
compression, multiplexing, etc.

Then, this extensions property just show which extensions are applied between
the client and the server. The client could not control which one should be
applied. This is same with JavaScript version of API. But some client want to
know which one is applied. E.g, some client may want to restrict connection
numbers when multiplexing is not applied. Thus, this interface is useful for a
PPAPI user, too.

BTW, I think this expectation depends on WebKit side implementation. This
"x-webkit-deflate-frame" will be changed to "deflate-frame" near the future. And
other extensions might be added with delimiter like "deflate-frame,mux", again.

So, yesterday I land another layout test where all extensions is disabled by
default. This WebKit change will be merged soon, and there, I keep old
expectation "" for this line. In that case, the change for this unit test is
just changing server URL like s/echo/echo-with-no-extension/.

[dmichael (off chromium), 2012-03-09 18:51:41]

Thanks for explaining. So it sounds like we should just wait until the other
work lands so you can do this CL without the "webkit" extension in the test?

[Takashi Toyoshima, 2012-03-09 19:11:34]

Right.
I think we should wait my CL (WebKit r110274) are rolled.
WebKit gardener is in JST now, so we might wait for more two days?
But, this is not urgent issue. We can wait it.

Anyway, I'll upload the CL which requires WebKit r110274 and ready for landing
as Patch Set 4.

[Takashi Toyoshima, 2012-03-09 19:26:43]

OK, the set 5 must work with the latest WebKit.
All we have to do is just wait for WebKit roll.

Thanks!

http://codereview.chromium.org/9619021/diff/11001/ppapi/tests/test_websocket.cc
File ppapi/tests/test_websocket.cc (left):

http://codereview.chromium.org/9619021/diff/11001/ppapi/tests/test_websocket....
ppapi/tests/test_websocket.cc:751:
ASSERT_TRUE(AreEqualWithString(ws.GetExtensions().pp_var(), ""));
CcInterfaces test doesn't use kEchoServer, so I move this initialized extension
property check to TestValidConnect for C API, and to TestUtilityValidConnect for
C++ API.

[dmichael (off chromium), 2012-03-09 19:35:58]

lgtm

[Takashi Toyoshima, 2012-03-09 22:57:28]

Adam roll new WebKit!
It's time to land.

[commit-bot: I haz the power, 2012-03-09 22:57:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/toyoshim@chromium.org/9619021/11001

[commit-bot: I haz the power, 2012-03-10 00:41:59]

Change committed as 125962