Issue 9619006: Adding a skeleton MediaStreamCenter.

Issue 9619006: Adding a skeleton MediaStreamCenter. (Closed)

Created:
8 years, 9 months ago by mflodman_chromium_OOO

Modified:
8 years, 9 months ago

Reviewers:
piman

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org, tommyw

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Adding a skeleton MediaStreamCenter. Replacing http://codereview.chromium.org/9309078/ BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125629

Patch Set 2 : Changes based on review by piman. #

Patch Set 3 : Adding a skeleton MediaStreamCenter. #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -2 lines)			Patch
M	content/content_renderer.gypi	View	1 2	1 chunk	+2 lines, -0 lines	0 comments	Download
A	content/renderer/media/media_stream_center.h	View		1 chunk	+50 lines, -0 lines	0 comments	Download
A	content/renderer/media/media_stream_center.cc	View		1 chunk	+44 lines, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.h	View	1	4 chunks	+11 lines, -0 lines	0 comments	Download
M	content/renderer/render_thread_impl.cc	View	1 2	3 chunks	+14 lines, -0 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/renderer/renderer_webkitplatformsupport_impl.cc	View	1	4 chunks	+20 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

mflodman_chromium_OOO

Hi, This is a first CL adding the MediaStreamCenter skeleton in RenderThreadImpl, replacing http://codereview.chromium.org/9309078/. Can ...

8 years, 9 months ago (2012-03-07 15:30:32 UTC) #1

piman

LGTM+nit http://codereview.chromium.org/9619006/diff/1/content/renderer/render_thread_impl.h File content/renderer/render_thread_impl.h (right): http://codereview.chromium.org/9619006/diff/1/content/renderer/render_thread_impl.h#newcode176 content/renderer/render_thread_impl.h:176: // The resulting object is owned by WebKit ...

8 years, 9 months ago (2012-03-07 16:24:54 UTC) #2

mflodman_chromium_OOO

Thanks for the quick review! http://codereview.chromium.org/9619006/diff/1/content/renderer/render_thread_impl.h File content/renderer/render_thread_impl.h (right): http://codereview.chromium.org/9619006/diff/1/content/renderer/render_thread_impl.h#newcode176 content/renderer/render_thread_impl.h:176: // The resulting object ...

8 years, 9 months ago (2012-03-07 19:28:27 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mflodman@chromium.org/9619006/3002

8 years, 9 months ago (2012-03-08 12:28:03 UTC) #4

Change committed as 125629

Expand Messages | Collapse Messages