Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Unified Diff: net/spdy/buffered_spdy_framer.h

Issue 9618002: SPDY - integration of spdy/3 code. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/buffered_spdy_framer.h
===================================================================
--- net/spdy/buffered_spdy_framer.h (revision 125802)
+++ net/spdy/buffered_spdy_framer.h (working copy)
@@ -51,9 +51,6 @@
// Called after a PING frame is received.
virtual void OnPing(const spdy::SpdyPingControlFrame& frame) = 0;
- // Called after a SETTINGS frame is received.
- virtual void OnSettings(const spdy::SpdySettingsControlFrame& frame) = 0;
-
// Called after a WINDOW_UPDATE frame is received.
virtual void OnWindowUpdate(
const spdy::SpdyWindowUpdateControlFrame& frame) = 0;
@@ -67,6 +64,7 @@
virtual void OnStreamFrameData(SpdyStreamId stream_id,
const char* data,
size_t len) = 0;
+ virtual void OnSetting(SpdySettingsIds id, uint8 flags, uint32 value) = 0;
Ryan Hamilton 2012/03/09 19:09:58 Please add a comment.
ramant (doing other things) 2012/03/10 01:14:09 Done.
private:
DISALLOW_COPY_AND_ASSIGN(BufferedSpdyFramerVisitorInterface);
@@ -95,6 +93,8 @@
virtual void OnStreamFrameData(SpdyStreamId stream_id,
const char* data,
size_t len) OVERRIDE;
+ virtual void OnSetting(
+ SpdySettingsIds id, uint8 flags, uint32 value) OVERRIDE;
virtual void OnDataFrameHeader(const SpdyDataFrame* frame) OVERRIDE;
// SpdyFramer methods.
@@ -105,7 +105,6 @@
SpdyFramer::SpdyState state() const;
bool MessageFullyRead();
bool HasError();
- bool ParseHeaderBlock(const SpdyFrame* frame, SpdyHeaderBlock* block);
SpdySynStreamControlFrame* CreateSynStream(SpdyStreamId stream_id,
SpdyStreamId associated_stream_id,
int priority,
@@ -135,6 +134,7 @@
const char* data,
uint32 len,
SpdyDataFlags flags);
+ SpdyPriority GetHighestPriority() const;
Ryan Hamilton 2012/03/09 19:09:58 Hm. This seems fine, but I wonder why we don't ha
ramant (doing other things) 2012/03/10 01:14:09 Agreed.
SpdyFrame* CompressFrame(const SpdyFrame& frame);
bool IsCompressible(const SpdyFrame& frame) const;

Powered by Google App Engine
This is Rietveld 408576698