Change Origin bound certs -> Domain bound certs.

net/base/origin_bound_cert_store.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_BASE_ORIGIN_BOUND_CERT_STORE_H_
 #define NET_BASE_ORIGIN_BOUND_CERT_STORE_H_
 #pragma once
 
 #include <string>
 #include <vector>
 
 #include "base/time.h"
 #include "net/base/net_export.h"
 #include "net/base/ssl_client_cert_type.h"
 
 namespace net {
 
-// An interface for storing and retrieving origin bound certs. Origin bound
-// certificates are specified in
-// http://balfanz.github.com/tls-obc-spec/draft-balfanz-tls-obc-00.html.
+// An interface for storing and retrieving domain bound certs.
+// There isn't a domain bound certs spec yet, but the old origin bound
+// certificates are specification is

[wtc, 2012/03/08 02:13:45]

Typo: are specification is

remove "are", or say "are specified in".

[mattm, 2012/03/15 01:48:44]

Done.

+// http://balfanz.github.com/tls-obc-spec/draft-balfanz-tls-obc-01.html.
 
 // Owned only by a single OriginBoundCertService object, which is responsible
 // for deleting it.
 
+// Note: For historical reasons, this class is called OriginBoundCertStore, but
+// it's really a DomainBoundCertStore.
 class NET_EXPORT OriginBoundCertStore {
  public:
-  // The OriginBoundCert class contains a private key in addition to the origin
+  // The OriginBoundCert class contains a private key in addition to the domain
   // cert, and cert type.
   class NET_EXPORT OriginBoundCert {
    public:
     OriginBoundCert();
-    OriginBoundCert(const std::string& origin,
+    OriginBoundCert(const std::string& domain,
                     SSLClientCertType type,
                     base::Time creation_time,
                     base::Time expiration_time,
                     const std::string& private_key,
                     const std::string& cert);
     ~OriginBoundCert();
 
-    // Origin, for instance "https://www.verisign.com:443"
-    const std::string& origin() const { return origin_; }
+    // Domain, for instance "verisign.com"
+    const std::string& domain() const { return domain_; }
     // TLS ClientCertificateType.
     SSLClientCertType type() const { return type_; }
     // The time the certificate was created, also the start of the certificate
     // validity period.
     base::Time creation_time() const { return creation_time_; }
     // The time after which this certificate is no longer valid.
     base::Time expiration_time() const { return expiration_time_; }
     // The encoding of the private key depends on the type.
     // rsa_sign: DER-encoded PrivateKeyInfo struct.
     // ecdsa_sign: DER-encoded EncryptedPrivateKeyInfo struct.
     const std::string& private_key() const { return private_key_; }
     // DER-encoded certificate.
     const std::string& cert() const { return cert_; }
 
    private:
-    std::string origin_;
+    std::string domain_;
     SSLClientCertType type_;
     base::Time creation_time_;
     base::Time expiration_time_;
     std::string private_key_;
     std::string cert_;
   };
 
   virtual ~OriginBoundCertStore() {}
 
   // TODO(rkn): File I/O may be required, so this should have an asynchronous
   // interface.
   // Returns true on success. |private_key_result| stores a DER-encoded
   // PrivateKeyInfo struct, |cert_result| stores a DER-encoded certificate,
   // |type| is the ClientCertificateType of the returned certificate,
   // |creation_time| stores the start of the validity period of the certificate
   // and |expiration_time| is the expiration time of the certificate.
-  // Returns false if no origin bound cert exists for the specified origin.
+  // Returns false if no domain bound cert exists for the specified domain.
   virtual bool GetOriginBoundCert(
-      const std::string& origin,
+      const std::string& domain,
       SSLClientCertType* type,
       base::Time* creation_time,
       base::Time* expiration_time,
       std::string* private_key_result,
       std::string* cert_result) = 0;
 
-  // Adds an origin bound cert and the corresponding private key to the store.
+  // Adds a domain bound cert and the corresponding private key to the store.
   virtual void SetOriginBoundCert(
-      const std::string& origin,
+      const std::string& domain,
       SSLClientCertType type,
       base::Time creation_time,
       base::Time expiration_time,
       const std::string& private_key,
       const std::string& cert) = 0;
 
-  // Removes an origin bound cert and the corresponding private key from the
+  // Removes an domain bound cert and the corresponding private key from the
   // store.
-  virtual void DeleteOriginBoundCert(const std::string& origin) = 0;
+  virtual void DeleteOriginBoundCert(const std::string& domain) = 0;
 
-  // Deletes all of the origin bound certs that have a creation_date greater
+  // Deletes all of the domain bound certs that have a creation_date greater
   // than or equal to |delete_begin| and less than |delete_end|.  If a
   // base::Time value is_null, that side of the comparison is unbounded.
   virtual void DeleteAllCreatedBetween(base::Time delete_begin,
                                        base::Time delete_end) = 0;
 
-  // Removes all origin bound certs and the corresponding private keys from
+  // Removes all domain bound certs and the corresponding private keys from
   // the store.
   virtual void DeleteAll() = 0;
 
-  // Returns all origin bound certs and the corresponding private keys.
+  // Returns all domain bound certs and the corresponding private keys.
   virtual void GetAllOriginBoundCerts(
       std::vector<OriginBoundCert>* origin_bound_certs) = 0;
 
   // Returns the number of certs in the store.
   // Public only for unit testing.
   virtual int GetCertCount() = 0;
 };
 
 }  // namespace net
 
 #endif  // NET_BASE_ORIGIN_BOUND_CERT_STORE_H_