Improve formatting of accessibility tests that dump the tree.

content/browser/accessibility/dump_accessibility_tree_helper.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "content/browser/accessibility/dump_accessibility_tree_helper.h"
+
+#include "base/memory/scoped_ptr.h"
+
+void DumpAccessibilityTreeHelper::DumpAccessibilityTree(
+    BrowserAccessibility* node, string16* contents) {
+  RecursiveDumpAccessibilityTree(node, contents, 0);
+}
+

[David Tseng, 2012/03/06 23:49:05]

nit: extra line.

[dmazzoni, 2012/03/08 07:10:37]

Done.

+
+void DumpAccessibilityTreeHelper::RecursiveDumpAccessibilityTree(
+    BrowserAccessibility* node, string16* contents, int indent) {
+  scoped_array<char> prefix(new char(indent + 1));
+  for (int i = 0; i < indent; i++)

[David Tseng, 2012/03/06 23:49:05]

nit: ++i

[dmazzoni, 2012/03/08 07:10:37]

Done.

+    prefix[i] = ' ';
+  prefix[indent] = 0;

[David Tseng, 2012/03/06 23:49:05]

nit: 0 -> NULL for clearity?

[dmazzoni, 2012/03/08 07:10:37]

I think NULL is only supposed to be for pointers. I'll use '\0' instead to make
it more clear it's a string terminator and not an integer.

+
+  *contents += ToString(node, prefix.get());
+  for (size_t i = 0; i < node->children().size(); ++i) {
+    RecursiveDumpAccessibilityTree(node->children()[i], contents, indent + 4);

[David Tseng, 2012/03/06 23:49:05]

nit: define the indent step as a constant somewhere.

[dmazzoni, 2012/03/08 07:10:37]

Done.

+  }
+}