Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5046)

Unified Diff: chrome/browser/download/chrome_download_manager_delegate.h

Issue 9617010: Move chrome.downloads out of experimental to dev (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix EDER incognito Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/download/chrome_download_manager_delegate.h
diff --git a/chrome/browser/download/chrome_download_manager_delegate.h b/chrome/browser/download/chrome_download_manager_delegate.h
index 1773a5aef9ad4c88e985be7111ea23a359be324c..7deb02f29a940613e1e9c47a5fb2039ca8e113e4 100644
--- a/chrome/browser/download/chrome_download_manager_delegate.h
+++ b/chrome/browser/download/chrome_download_manager_delegate.h
@@ -21,6 +21,7 @@
class CrxInstaller;
class DownloadHistory;
class DownloadPrefs;
+class ExtensionDownloadsEventRouter;
class Profile;
namespace content {
@@ -193,6 +194,14 @@ class ChromeDownloadManagerDelegate
content::NotificationRegistrar registrar_;
+ // The ExtensionDownloadsEventRouter dispatches download creation, change, and
+ // erase events to extensions. Like ChromeDownloadManagerDelegate, it's a
+ // chrome-level concept and its lifetime should match DownloadManager. There
+ // should be a separate EDER for on-record and off-record managers.
+ // There does not appear to be a separate ExtensionSystem for on-record and
+ // off-record profiles, so ExtensionSystem cannot own the EDER.
+ scoped_ptr<ExtensionDownloadsEventRouter> extension_event_router_;
+
DISALLOW_COPY_AND_ASSIGN(ChromeDownloadManagerDelegate);
};

Powered by Google App Engine
This is Rietveld 408576698