Move chrome.downloads out of experimental to dev

tools/json_schema_compiler/model.py

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import copy
 import os.path
 import re
 
 class ParseException(Exception):
   """Thrown when data in the model is invalid.
@@ skipping 172 matching lines @@
     self.optional = json.get('optional', False)
     self.has_value = False
     self.description = json.get('description')
     self.parent = parent
     _AddProperties(self, json)
     if is_additional_properties:
       self.type_ = PropertyType.ADDITIONAL_PROPERTIES
     elif '$ref' in json:
       self.ref_type = json['$ref']
       self.type_ = PropertyType.REF
-    elif 'enum' in json:
+    elif 'enum' in json and all(isinstance(value, basestring)
+                                for value in json['enum']):

[not at google - send to devlin, 2012/06/12 18:34:38]

Could you move the second check inside this block? As it stands this will fall
through to a generic ParseException; we should at least throw one with a nicer
error message (if one at all).

[benjhayden, 2012/06/12 20:15:42]

Actually, I did this specifically so that it would fall through to the |'type'
in json| branch, which handles |legalValues=(integer*)|.

       self.enum_values = []
       for value in json['enum']:
         self.enum_values.append(value)
       self.type_ = PropertyType.ENUM
     elif 'type' in json:
       json_type = json['type']
       if json_type == 'string':
         self.type_ = PropertyType.STRING
       elif json_type == 'any':
         self.type_ = PropertyType.ANY
@@ skipping 157 matching lines @@
     # handled in pure Javascript on the render process (and .: never reach
     # C++ let alone the browser).
     if property_json.get('type') == 'function':
       continue
     model.properties[name] = Property(
         model,
         name,
         property_json,
         from_json=from_json,
         from_client=from_client)