Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: frog/leg/ssa/codegen.dart

Issue 9616058: Implement parsing and resolving of type-variables. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Fix merge error. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« frog/leg/scanner/listener.dart ('K') | « frog/leg/ssa/builder.dart ('k') | frog/leg/tree/nodes.dart » ('j') | frog/leg/typechecker.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: frog/leg/ssa/codegen.dart
diff --git a/frog/leg/ssa/codegen.dart b/frog/leg/ssa/codegen.dart
index 7c15342fd83f977caa2b01215cdce01b557b2cd7..5c0d1bf97c074a7fc2a67f1c5a401469cb023f9d 100644
--- a/frog/leg/ssa/codegen.dart
+++ b/frog/leg/ssa/codegen.dart
@@ -970,7 +970,10 @@ class SsaCodeGenerator implements HVisitor {
}
void visitIs(HIs node) {
- Element element = node.typeExpression;
+ ClassElement element = node.typeExpression;
ngeoffray 2012/03/15 11:47:40 This is not right, because it could be a typedef.
karlklose 2012/03/16 14:58:47 Done.
+ if (node.typeExpression.kind === ElementKind.TYPE_VARIABLE) {
+ compiler.unimplemented("visitIs for type variables");
+ }
compiler.registerIsCheck(element);
LibraryElement coreLibrary = compiler.coreLibrary;
ClassElement objectClass = coreLibrary.find(const SourceString('Object'));
« frog/leg/scanner/listener.dart ('K') | « frog/leg/ssa/builder.dart ('k') | frog/leg/tree/nodes.dart » ('j') | frog/leg/typechecker.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698