chrome/browser/ui/panels/panel_window_controller_cocoa.mm - Issue 9616037: Change panel drag related methods to use mouse location in screen coordinates.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

Issue 9616037: Change panel drag related methods to use mouse location in screen coordinates. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix line endings for new mac files Created 8 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/panels/panel_titlebar_view_cocoa.mm ('K') | « chrome/browser/ui/panels/panel_window_controller_cocoa.h ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/panels/panel_window_controller_cocoa.mm

diff --git a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm

index 97f05e339422a55d03b1bd7ca2f473e21867d7a5..e0cb9e97c1505b5f3a68b83846269fbfed748491 100644

--- a/chrome/browser/ui/panels/panel_window_controller_cocoa.mm

+++ b/chrome/browser/ui/panels/panel_window_controller_cocoa.mm

@@ -32,6 +32,7 @@

#include "chrome/browser/ui/panels/panel_settings_menu_model.h"

#include "chrome/browser/ui/panels/panel_strip.h"

#import "chrome/browser/ui/panels/panel_titlebar_view_cocoa.h"

+#import "chrome/browser/ui/panels/panel_utils_cocoa.h"

#include "chrome/browser/ui/toolbar/encoding_menu_controller.h"

#include "chrome/common/chrome_notification_types.h"

#include "content/public/browser/notification_service.h"

@@ -408,9 +409,11 @@ enum {

return windowShim_->panel()->draggable();

}

-- (void)startDrag {

+- (void)startDrag:(NSPoint)mouseLocation {

animateOnBoundsChange_ = NO;

- windowShim_->panel()->manager()->StartDragging(windowShim_->panel());

+ windowShim_->panel()->manager()->StartDragging(

+ windowShim_->panel(),

+ cocoa_utils::ConvertPointFromCocoaCoordinates(mouseLocation));

}

- (void)endDrag:(BOOL)cancelled {

@@ -418,9 +421,9 @@ enum {

windowShim_->panel()->manager()->EndDragging(cancelled);

}

-- (void)dragWithDeltaX:(int)deltaX

- deltaY:(int)deltaY {

- windowShim_->panel()->manager()->Drag(deltaX, deltaY);

+- (void)drag:(NSPoint)mouseLocation {

+ windowShim_->panel()->manager()->Drag(

+ ConvertPointFromCocoaCoordinates(mouseLocation));

}

- (void)setPanelFrame:(NSRect)frame