Change panel drag related methods to use mouse location in screen coordinates.

chrome/browser/ui/panels/panel_window_controller_cocoa.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_window_controller_cocoa.h"
 
 #import <Cocoa/Cocoa.h>
 
 #include "base/logging.h"
 #include "base/mac/bundle_locations.h"
@@ skipping 14 matching lines @@
 #import "chrome/browser/ui/cocoa/menu_controller.h"
 #import "chrome/browser/ui/cocoa/tab_contents/favicon_util.h"
 #import "chrome/browser/ui/cocoa/tab_contents/tab_contents_controller.h"
 #import "chrome/browser/ui/cocoa/tabs/throbber_view.h"
 #include "chrome/browser/ui/panels/panel_bounds_animation.h"
 #include "chrome/browser/ui/panels/panel_browser_window_cocoa.h"
 #include "chrome/browser/ui/panels/panel_manager.h"
 #include "chrome/browser/ui/panels/panel_settings_menu_model.h"
 #include "chrome/browser/ui/panels/panel_strip.h"
 #import "chrome/browser/ui/panels/panel_titlebar_view_cocoa.h"
+#import "chrome/browser/ui/panels/panel_utils_cocoa.h"
 #include "chrome/browser/ui/toolbar/encoding_menu_controller.h"
 #include "chrome/common/chrome_notification_types.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_widget_host_view.h"
 #include "content/public/browser/web_contents.h"
 #include "grit/ui_resources.h"
 #include "ui/base/resource/resource_bundle.h"
 #include "ui/gfx/image/image.h"
 #include "ui/gfx/mac/nsimage_cache.h"
 
@@ skipping 356 matching lines @@
 
   [NSMenu popUpContextMenu:[settingsMenuController menu]
                  withEvent:[NSApp currentEvent]
                    forView:button];
 }
 
 - (BOOL)isDraggable {
   return windowShim_->panel()->draggable();
 }
 
-- (void)startDrag {
+- (void)startDrag:(NSPoint)mouseLocation {
   animateOnBoundsChange_ = NO;
-  windowShim_->panel()->manager()->StartDragging(windowShim_->panel());
+  windowShim_->panel()->manager()->StartDragging(
+      windowShim_->panel(),
+      cocoa_utils::ConvertPointFromCocoaCoordinates(mouseLocation));

[jennb, 2012/03/07 00:17:46]

The .h said mouseLocation was already in screen coordinates. Which is it? Ditto
for drag().

[jianli, 2012/03/07 00:46:49]

Added comment.

 }
 
 - (void)endDrag:(BOOL)cancelled {
   animateOnBoundsChange_ = YES;
   windowShim_->panel()->manager()->EndDragging(cancelled);
 }
 
-- (void)dragWithDeltaX:(int)deltaX
-                deltaY:(int)deltaY {
-  windowShim_->panel()->manager()->Drag(deltaX, deltaY);
+- (void)drag:(NSPoint)mouseLocation {
+  windowShim_->panel()->manager()->Drag(
+      cocoa_utils::ConvertPointFromCocoaCoordinates(mouseLocation));
 }
 
 - (void)setPanelFrame:(NSRect)frame
               animate:(BOOL)animate {
   // Setup the whole window as the tracking area so that we can get notified
   // when the mouse enters or leaves the window. This will make us be able to
   // show or hide settings button accordingly.
   NSRect localBounds = frame;
   localBounds.origin = NSZeroPoint;
 
@@ skipping 196 matching lines @@
 
 - (BOOL)canBecomeKeyWindow {
   // Panel can only gain focus if it is expanded. Minimized panels do not
   // participate in Cmd-~ rotation.
   // TODO(dimich): If it will be ever desired to expand/focus the Panel on
   // keyboard navigation or via main menu, the care should be taken to avoid
   // cases when minimized Panel is getting keyboard input, invisibly.
   return windowShim_->panel()->expansion_state() == Panel::EXPANDED;
 }
 @end