Issue 9616033: Merge CrossFileUtilHelper to FileUtilHelper as Copy() and Move().

Issue 9616033: Merge CrossFileUtilHelper to FileUtilHelper as Copy() and Move(). (Closed)

Created:
8 years, 9 months ago by tzik

Modified:
8 years, 9 months ago

Reviewers:
kinuko

CC:
chromium-reviews, kinuko+watch, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Merge CrossFileUtilHelper to FileUtilHelper as Copy() and Move(). BUG=114732 TEST="existing tests" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125558

Patch Set 4 : address comments #

Patch Set 5 : rebase #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+285 lines, -295 lines)			Patch
D	webkit/fileapi/cross_file_util_helper.h	View		1 chunk	+0 lines, -71 lines	0 comments	Download
D	webkit/fileapi/cross_file_util_helper.cc	View	1 2 3 4	1 chunk	+0 lines, -187 lines	0 comments	Download
M	webkit/fileapi/file_system_file_util_proxy.cc	View		3 chunks	+4 lines, -12 lines	0 comments	Download
M	webkit/fileapi/file_system_file_util_unittest.cc	View	1	2 chunks	+16 lines, -10 lines	0 comments	Download
M	webkit/fileapi/file_system_test_helper.h	View	1	1 chunk	+0 lines, -1 line	0 comments	Download
M	webkit/fileapi/file_system_test_helper.cc	View	1	2 chunks	+3 lines, -12 lines	0 comments	Download
M	webkit/fileapi/file_util_helper.h	View		1 chunk	+14 lines, -0 lines	0 comments	Download
M	webkit/fileapi/file_util_helper.cc	View	1 2 3 4	2 chunks	+248 lines, -0 lines	0 comments	Download
M	webkit/fileapi/webkit_fileapi.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

kinuko

http://codereview.chromium.org/9616033/diff/1007/webkit/fileapi/file_util_helper.cc File webkit/fileapi/file_util_helper.cc (right): http://codereview.chromium.org/9616033/diff/1007/webkit/fileapi/file_util_helper.cc#newcode96 webkit/fileapi/file_util_helper.cc:96: } nit: looks like we can/should remove { } ...

8 years, 9 months ago (2012-03-06 23:46:36 UTC) #3

tzik

Thanks for reviewing. http://codereview.chromium.org/9616033/diff/1007/webkit/fileapi/file_util_helper.cc File webkit/fileapi/file_util_helper.cc (right): http://codereview.chromium.org/9616033/diff/1007/webkit/fileapi/file_util_helper.cc#newcode96 webkit/fileapi/file_util_helper.cc:96: } On 2012/03/06 23:46:36, kinuko wrote: ...

8 years, 9 months ago (2012-03-07 00:27:13 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/9616033/9002

8 years, 9 months ago (2012-03-08 02:52:08 UTC) #5

Change committed as 125558

Expand Messages | Collapse Messages