Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9615050: Remove NewRequiredCallback. (Closed)

Created:
8 years, 9 months ago by brettw
Modified:
8 years, 9 months ago
Reviewers:
Lambros, viettrungluu
CC:
chromium-reviews, jamiewalch+watch_chromium.org, garykac+watch_chromium.org, sanjeevr, simonmorris+watch_chromium.org, dcaiafa+watch_chromium.org, wez+watch_chromium.org, amit, hclam+watch_chromium.org, jam, joi+watch-content_chromium.org, lambroslambrou+watch_chromium.org, darin-cc_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Remove NewRequiredCallback. This is the same as NewCallback, and we want people to normally use the "required" type. So just having them call NewCallback is usually the right thing. This converts the existing callers to just say NewCallback. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125965

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -126 lines) Patch
M ppapi/examples/audio_input/audio_input.cc View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/examples/flash_topmost/flash_topmost.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ppapi/examples/gamepad/gamepad.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M ppapi/examples/mouse_lock/mouse_lock.cc View 3 chunks +5 lines, -8 lines 0 comments Download
M ppapi/examples/url_loader/streaming.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/file_downloader.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 1 2 5 chunks +8 lines, -10 lines 0 comments Download
M ppapi/tests/test_flash.cc View 1 chunk +1 line, -1 line 0 comments Download
M ppapi/tests/test_flash_message_loop.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M ppapi/utility/completion_callback_factory.h View 1 2 3 9 chunks +1 line, -92 lines 0 comments Download
M remoting/protocol/pepper_transport_socket_adapter.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
brettw
8 years, 9 months ago (2012-03-08 06:23:50 UTC) #1
viettrungluu
lgtm otherwise http://codereview.chromium.org/9615050/diff/26/ppapi/utility/completion_callback_factory.h File ppapi/utility/completion_callback_factory.h (right): http://codereview.chromium.org/9615050/diff/26/ppapi/utility/completion_callback_factory.h#newcode150 ppapi/utility/completion_callback_factory.h:150: /// NewCallback() is equivalent to NewCallback() below. ...
8 years, 9 months ago (2012-03-09 06:16:23 UTC) #2
Lambros
remoting LGTM
8 years, 9 months ago (2012-03-09 18:29:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/9615050/19001
8 years, 9 months ago (2012-03-09 21:34:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/brettw@chromium.org/9615050/19013
8 years, 9 months ago (2012-03-09 21:36:28 UTC) #5
commit-bot: I haz the power
8 years, 9 months ago (2012-03-10 01:01:13 UTC) #6 
Change committed as 125965

Powered by Google App Engine
This is Rietveld 408576698