Avoid loading ws2_32.dll just to get htons() and friends.

crypto/p224.cc

Index: crypto/p224.cc
diff --git a/crypto/p224.cc b/crypto/p224.cc
index a7cc66b0be3c0195ee7f55a4def7843f25d7af43..1bc39b2c5ee5369937ddaaf2fb4f23a979b6f2c6 100644
--- a/crypto/p224.cc
+++ b/crypto/p224.cc
@@ -13,6 +13,15 @@
 
 #include "base/sys_byteorder.h"
 
+#if defined(OS_WIN)
+// Allow htonl/ntohl to be called without requiring ws2_32.dll to be loaded,
+// which isn't available in Chrome's sandbox. See crbug.com/116591.
+#define ntohl(x) _byteswap_ulong(x)
+#define htonl(x) _byteswap_ulong(x)
+#endif // OS_WIN

[Ryan Sleevi, 2012/03/06 01:56:47]

This is the second or third time I've seen this pattern, which makes me think it
would be better served by updating base/sys_byteorder.h

After all, http://msdn.microsoft.com/en-us/library/a3140177(v=vs.80).aspx

+
+
+
 namespace {
 
 // Field element functions.