Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Side by Side Diff: chrome/browser/predictors/autocomplete_action_predictor.h

Issue 9610006: Refactoring, moving and renaming the NetworkActionPredictor. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Changing DB to PKS from RefcountedPKS and addressing comments. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_AUTOCOMPLETE_NETWORK_ACTION_PREDICTOR_H_ 5 #ifndef CHROME_BROWSER_PREDICTORS_AUTOCOMPLETE_ACTION_PREDICTOR_H_
6 #define CHROME_BROWSER_AUTOCOMPLETE_NETWORK_ACTION_PREDICTOR_H_ 6 #define CHROME_BROWSER_PREDICTORS_AUTOCOMPLETE_ACTION_PREDICTOR_H_
7 #pragma once 7 #pragma once
8 8
9 #include <map> 9 #include <map>
10 #include <set>
10 11
11 #include "base/gtest_prod_util.h" 12 #include "base/gtest_prod_util.h"
12 #include "base/memory/scoped_ptr.h" 13 #include "base/memory/scoped_ptr.h"
13 #include "base/memory/weak_ptr.h" 14 #include "base/memory/weak_ptr.h"
14 #include "base/string16.h" 15 #include "base/string16.h"
15 #include "chrome/browser/autocomplete/network_action_predictor_database.h" 16 #include "chrome/browser/predictors/autocomplete_action_predictor_table.h"
16 #include "chrome/browser/profiles/profile_keyed_service.h" 17 #include "chrome/browser/profiles/profile_keyed_service.h"
17 #include "content/public/browser/notification_observer.h" 18 #include "content/public/browser/notification_observer.h"
18 #include "content/public/browser/notification_registrar.h" 19 #include "content/public/browser/notification_registrar.h"
19 #include "googleurl/src/gurl.h" 20 #include "googleurl/src/gurl.h"
20 21
21 struct AutocompleteLog; 22 struct AutocompleteLog;
22 struct AutocompleteMatch; 23 struct AutocompleteMatch;
23 class AutocompleteResult; 24 class AutocompleteResult;
24 class HistoryService; 25 class HistoryService;
26 class PredictorsDOMHandler;
25 class Profile; 27 class Profile;
26 28
27 namespace history { 29 namespace history {
28 class URLDatabase; 30 class URLDatabase;
29 } 31 }
30 32
33 namespace predictors {
34
31 // This class is responsible for determining the correct predictive network 35 // This class is responsible for determining the correct predictive network
32 // action to take given for a given AutocompleteMatch and entered text. it uses 36 // action to take given for a given AutocompleteMatch and entered text. it uses
33 // a NetworkActionPredictorDatabase accessed asynchronously on the DB thread to 37 // a AutocompleteActionPredictorTable accessed asynchronously on the DB thread
34 // permanently store the data used to make predictions, and keeps local caches 38 // to permanently store the data used to make predictions, and keeps local
35 // of that data to be able to make predictions synchronously on the UI thread 39 // caches of that data to be able to make predictions synchronously on the UI
36 // where it lives. It can be accessed as a weak pointer so that it can safely 40 // thread where it lives. It can be accessed as a weak pointer so that it can
37 // use PostTaskAndReply without fear of crashes if it is destroyed before the 41 // safely use PostTaskAndReply without fear of crashes if it is destroyed before
38 // reply triggers. This is necessary during initialization. 42 // the reply triggers. This is necessary during initialization.
39 class NetworkActionPredictor 43 class AutocompleteActionPredictor
40 : public ProfileKeyedService, 44 : public ProfileKeyedService,
41 public content::NotificationObserver, 45 public content::NotificationObserver,
42 public base::SupportsWeakPtr<NetworkActionPredictor> { 46 public base::SupportsWeakPtr<AutocompleteActionPredictor> {
43 public: 47 public:
44 enum Action { 48 enum Action {
45 ACTION_PRERENDER = 0, 49 ACTION_PRERENDER = 0,
46 ACTION_PRECONNECT, 50 ACTION_PRECONNECT,
47 ACTION_NONE, 51 ACTION_NONE,
48 LAST_PREDICT_ACTION = ACTION_NONE 52 LAST_PREDICT_ACTION = ACTION_NONE
49 }; 53 };
50 54
51 explicit NetworkActionPredictor(Profile* profile); 55 explicit AutocompleteActionPredictor(Profile* profile);
52 virtual ~NetworkActionPredictor(); 56 virtual ~AutocompleteActionPredictor();
53 57
54 static void set_hit_weight(double weight) { hit_weight_ = weight; } 58 static void set_hit_weight(double weight) { hit_weight_ = weight; }
55 static double get_hit_weight() { return hit_weight_; } 59 static double get_hit_weight() { return hit_weight_; }
56 60
57 // Registers an AutocompleteResult for a given |user_text|. This will be used 61 // Registers an AutocompleteResult for a given |user_text|. This will be used
58 // when the user navigates from the Omnibox to determine early opportunities 62 // when the user navigates from the Omnibox to determine early opportunities
59 // to predict their actions. 63 // to predict their actions.
60 void RegisterTransitionalMatches(const string16& user_text, 64 void RegisterTransitionalMatches(const string16& user_text,
61 const AutocompleteResult& result); 65 const AutocompleteResult& result);
62 66
63 // Clears any transitional matches that have been registered. Called when, for 67 // Clears any transitional matches that have been registered. Called when, for
64 // example, the AutocompleteEditModel is reverted. 68 // example, the AutocompleteEditModel is reverted.
65 void ClearTransitionalMatches(); 69 void ClearTransitionalMatches();
66 70
67 // Return the recommended action given |user_text|, the text the user has 71 // Return the recommended action given |user_text|, the text the user has
68 // entered in the Omnibox, and |match|, the suggestion from Autocomplete. 72 // entered in the Omnibox, and |match|, the suggestion from Autocomplete.
69 // This method uses information from the ShortcutsBackend including how much 73 // This method uses information from the ShortcutsBackend including how much
70 // of the matching entry the user typed, and how long it's been since the user 74 // of the matching entry the user typed, and how long it's been since the user
71 // visited the matching URL, to calculate a score between 0 and 1. This score 75 // visited the matching URL, to calculate a score between 0 and 1. This score
72 // is then mapped to an Action. 76 // is then mapped to an Action.
73 Action RecommendAction(const string16& user_text, 77 Action RecommendAction(const string16& user_text,
74 const AutocompleteMatch& match) const; 78 const AutocompleteMatch& match) const;
75 79
76 // Return true if the suggestion type warrants a TCP/IP preconnection. 80 // Return true if the suggestion type warrants a TCP/IP preconnection.
77 // i.e., it is now quite likely that the user will select the related domain. 81 // i.e., it is now quite likely that the user will select the related domain.
78 static bool IsPreconnectable(const AutocompleteMatch& match); 82 static bool IsPreconnectable(const AutocompleteMatch& match);
79 83
80 private: 84 private:
81 friend class NetworkActionPredictorTest; 85 friend class AutocompleteActionPredictorTest;
82 friend class NetworkActionPredictorDOMHandler; 86 friend class ::PredictorsDOMHandler;
83 87
84 struct TransitionalMatch { 88 struct TransitionalMatch {
85 TransitionalMatch(); 89 TransitionalMatch();
86 ~TransitionalMatch(); 90 ~TransitionalMatch();
87 91
88 string16 user_text; 92 string16 user_text;
89 std::vector<GURL> urls; 93 std::vector<GURL> urls;
90 94
91 bool operator==(const string16& other_user_text) const { 95 bool operator==(const string16& other_user_text) const {
92 return user_text == other_user_text; 96 return user_text == other_user_text;
(...skipping 13 matching lines...) Expand all
106 return (user_text == rhs.user_text) && (url == rhs.url); 110 return (user_text == rhs.user_text) && (url == rhs.url);
107 } 111 }
108 }; 112 };
109 113
110 struct DBCacheValue { 114 struct DBCacheValue {
111 int number_of_hits; 115 int number_of_hits;
112 int number_of_misses; 116 int number_of_misses;
113 }; 117 };
114 118
115 typedef std::map<DBCacheKey, DBCacheValue> DBCacheMap; 119 typedef std::map<DBCacheKey, DBCacheValue> DBCacheMap;
116 typedef std::map<DBCacheKey, NetworkActionPredictorDatabase::Row::Id> 120 typedef std::map<DBCacheKey, AutocompleteActionPredictorTable::Row::Id>
117 DBIdCacheMap; 121 DBIdCacheMap;
118 122
119 static const int kMaximumDaysToKeepEntry; 123 static const int kMaximumDaysToKeepEntry;
120 124
121 // Multiplying factor applied to the |number_of_hits| for a database entry 125 // Multiplying factor applied to the |number_of_hits| for a database entry
122 // when calculating the confidence. It is currently set by a field trial so is 126 // when calculating the confidence. It is currently set by a field trial so is
123 // static. Once the field trial ends, this will be a constant value. 127 // static. Once the field trial ends, this will be a constant value.
124 static double hit_weight_; 128 static double hit_weight_;
125 129
126 // ProfileKeyedService 130 // ProfileKeyedService
127 virtual void Shutdown() OVERRIDE; 131 virtual void Shutdown() OVERRIDE;
128 132
129 // NotificationObserver 133 // NotificationObserver
130 virtual void Observe(int type, 134 virtual void Observe(int type,
131 const content::NotificationSource& source, 135 const content::NotificationSource& source,
132 const content::NotificationDetails& details) OVERRIDE; 136 const content::NotificationDetails& details) OVERRIDE;
133 137
134 // Called when NOTIFICATION_OMNIBOX_OPENED_URL is observed. 138 // Called when NOTIFICATION_OMNIBOX_OPENED_URL is observed.
135 void OnOmniboxOpenedUrl(const AutocompleteLog& log); 139 void OnOmniboxOpenedUrl(const AutocompleteLog& log);
136 140
137 // Deletes any old or invalid entries from the local caches. |url_db| and 141 // Deletes any old or invalid entries from the local caches. |url_db| and
138 // |id_list| must not be NULL. Every row id deleted will be added to id_list. 142 // |id_list| must not be NULL. Every row id deleted will be added to id_list.
139 void DeleteOldIdsFromCaches( 143 void DeleteOldIdsFromCaches(
140 history::URLDatabase* url_db, 144 history::URLDatabase* url_db,
141 std::vector<NetworkActionPredictorDatabase::Row::Id>* id_list); 145 std::vector<AutocompleteActionPredictorTable::Row::Id>* id_list);
142 146
143 // Called to delete any old or invalid entries from the database. Called after 147 // Called to delete any old or invalid entries from the database. Called after
144 // the local caches are created once the history service is available. 148 // the local caches are created once the history service is available.
145 void DeleteOldEntries(history::URLDatabase* url_db); 149 void DeleteOldEntries(history::URLDatabase* url_db);
146 150
147 // Called to populate the local caches. This also calls DeleteOldEntries 151 // Called to populate the local caches. This also calls DeleteOldEntries
148 // if the history service is available, or registers for the notification of 152 // if the history service is available, or registers for the notification of
149 // it becoming available. 153 // it becoming available.
150 void CreateCaches( 154 void CreateCaches(
151 std::vector<NetworkActionPredictorDatabase::Row>* row_buffer); 155 std::vector<AutocompleteActionPredictorTable::Row>* row_buffer);
152 156
153 // Attempts to call DeleteOldEntries if the in-memory database has been loaded 157 // Attempts to call DeleteOldEntries if the in-memory database has been loaded
154 // by |service|. Returns success as a boolean. 158 // by |service|. Returns success as a boolean.
155 bool TryDeleteOldEntries(HistoryService* service); 159 bool TryDeleteOldEntries(HistoryService* service);
156 160
157 // Uses local caches to calculate an exact percentage prediction that the user 161 // Uses local caches to calculate an exact percentage prediction that the user
158 // will take a particular match given what they have typed. |is_in_db| is set 162 // will take a particular match given what they have typed. |is_in_db| is set
159 // to differentiate trivial zero results resulting from a match not being 163 // to differentiate trivial zero results resulting from a match not being
160 // found from actual zero results where the calculation returns 0.0. 164 // found from actual zero results where the calculation returns 0.0.
161 double CalculateConfidence(const string16& user_text, 165 double CalculateConfidence(const string16& user_text,
162 const AutocompleteMatch& match, 166 const AutocompleteMatch& match,
163 bool* is_in_db) const; 167 bool* is_in_db) const;
164 168
165 // Calculates the confidence for an entry in the DBCacheMap. 169 // Calculates the confidence for an entry in the DBCacheMap.
166 double CalculateConfidenceForDbEntry(DBCacheMap::const_iterator iter) const; 170 double CalculateConfidenceForDbEntry(DBCacheMap::const_iterator iter) const;
167 171
168 // Adds a row to the database and caches. 172 // Adds a row to the database and caches.
169 void AddRow(const DBCacheKey& key, 173 void AddRow(const DBCacheKey& key,
170 const NetworkActionPredictorDatabase::Row& row); 174 const AutocompleteActionPredictorTable::Row& row);
171 175
172 // Updates a row in the database and the caches. 176 // Updates a row in the database and the caches.
173 void UpdateRow(DBCacheMap::iterator it, 177 void UpdateRow(DBCacheMap::iterator it,
174 const NetworkActionPredictorDatabase::Row& row); 178 const AutocompleteActionPredictorTable::Row& row);
175 179
176 // Removes all rows from the database and caches. 180 // Removes all rows from the database and caches.
177 void DeleteAllRows(); 181 void DeleteAllRows();
178 182
179 // Removes rows from the database and caches that contain a URL in |urls|. 183 // Removes rows from the database and caches that contain a URL in |urls|.
180 void DeleteRowsWithURLs(const std::set<GURL>& urls); 184 void DeleteRowsWithURLs(const std::set<GURL>& urls);
181 185
182 // Used to batch operations on the database.
183 void BeginTransaction();
184 void CommitTransaction();
185
186 Profile* profile_; 186 Profile* profile_;
187 scoped_refptr<NetworkActionPredictorDatabase> db_; 187 scoped_refptr<AutocompleteActionPredictorTable> db_;
188 content::NotificationRegistrar notification_registrar_; 188 content::NotificationRegistrar notification_registrar_;
189 189
190 // This is cleared after every Omnibox navigation. 190 // This is cleared after every Omnibox navigation.
191 std::vector<TransitionalMatch> transitional_matches_; 191 std::vector<TransitionalMatch> transitional_matches_;
192 192
193 // This allows us to predict the effect of confidence threshold changes on 193 // This allows us to predict the effect of confidence threshold changes on
194 // accuracy. 194 // accuracy.
195 mutable std::vector<std::pair<GURL, double> > tracked_urls_; 195 mutable std::vector<std::pair<GURL, double> > tracked_urls_;
196 196
197 DBCacheMap db_cache_; 197 DBCacheMap db_cache_;
198 DBIdCacheMap db_id_cache_; 198 DBIdCacheMap db_id_cache_;
199 199
200 bool initialized_; 200 bool initialized_;
201 201
202 DISALLOW_COPY_AND_ASSIGN(NetworkActionPredictor); 202 DISALLOW_COPY_AND_ASSIGN(AutocompleteActionPredictor);
203 }; 203 };
204 204
205 #endif // CHROME_BROWSER_AUTOCOMPLETE_NETWORK_ACTION_PREDICTOR_H_ 205 } // namespace predictors
206
207 #endif // CHROME_BROWSER_PREDICTORS_AUTOCOMPLETE_ACTION_PREDICTOR_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698