css hack n' slash, continued: New styles for checkboxes and radios.

chrome/browser/resources/shared/css/chrome_shared2.css

 /* Copyright (c) 2012 The Chromium Authors. All rights reserved.
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file. */
 
 /* This file holds CSS that should be shared, in theory, by all user-visible
  * chrome:// pages. This contrasts chrome_shared.css, which it is meant to
  * replace, but has CSS specific to options and options-like pages. */
 
-@import url("chrome://resources/css/button.css");
-@import url("chrome://resources/css/checkbox.css");
+@import url("chrome://resources/css/widgets.css");

[Dan Beam, 2012/03/06 04:47:07]

wait, _why_ are we importing this?

[Evan Stade, 2012/03/06 05:18:15]

so that people who import chrome_shared2.css will get that style as well (?)

[Dan Beam, 2012/03/06 05:50:10]

I thought there would be more than this, but I assumed people wouldn't know that
shared also included button.css/checkbox.css and would double include like this
-
http://code.google.com/codesearch#OAMlx_jo-ck/src/chrome/browser/resources/he...

[Patrick Dubroy, 2012/03/06 18:45:19]

  On 2012/03/06 05:50:10, Dan Beam wrote:
For someone new to the webUI code, I think it would be good if there was a
single include. Most people will probably just follow the example of an existing
file, so as long as we clean up the other files to not do double include, I
don't think people will be confused.

[Evan Stade, 2012/03/06 22:54:51]

yea, we should fix double includes and don't do them in the future.

 
 /* Prevent CSS from overriding the hidden property. */
 [hidden] {
   display: none !important;
 }
 
 html.loading * {
   -webkit-transition-delay: 0 !important;
   -webkit-transition-duration: 0 !important;
 }
@@ skipping 38 matching lines @@
 
 a {
   color: rgb(17, 85, 204);
   text-decoration: underline;
 }
 
 a:active {
   color: rgb(5, 37, 119);
 }
 
-div.checkbox,
-div.radio {
-  margin: 0.45em 0;
-}
-
-input[type=radio] ~ span,
-input[type=checkbox] ~ span {
-  color: #444;
-}
-
-/* TEXT */
-/* TODO(estade): add more types here? */
-input[type='password'],
-input[type='search'],
-input[type='text'],
-input[type='url'],
-input:not([type]) {
-  border: 1px solid #bfbfbf;
-  border-radius: 2px;
-  font: inherit;
-  height: 2em;
-  margin: 0;
-  padding: 3px;
-}
-
-input[type='search'] {
-  /* NOTE: Keep a relatively high min-width for this so we don't obscure the end
-   * of the default text in relatively spacious languages (i.e. German). */
-  min-width: 160px;
-}
-
-input[type='text']:disabled {
-  color: #888;
-}
-
 /*
  * Add padding to increase the touchable area of search box. Use original font
  * size to avoid the width of search box exceeding the width of navbar.
  */
 html[touch-optimized] input[type='search'] {
   font-size: 13px;
   padding: 5px;
 }
 
 html[touch-optimized] input[type='search']::-webkit-search-cancel-button {
   -webkit-transform: scale(1.5);
 }
 
+/* Header *********************************************************************/

[Dan Beam, 2012/03/06 04:47:07]

Headers?

[Evan Stade, 2012/03/06 05:18:15]

what is the verb in this question

[Dan Beam, 2012/03/06 05:50:10]

s/Header/Headers/ IMO or Header styles as Header makes little sense to me as a
class of objects (it sounds singular, i.e. it should be a #header).

[Evan Stade, 2012/03/06 22:54:51]

well, I removed this whole section in a previous patch, so I guess it's moot.

+
 header > .search-field-container,
 header > button {
   position: absolute;
   right: 100px;
   top: 21px;
 }
 
 html[dir='rtl'] header > .search-field-container,
 html[dir='rtl'] header > button {
   left: 100px;
@@ skipping 52 matching lines @@
  * For now it's a bandaid until we install open sans properly. */
 <if expr="is_posix and not is_macosx and not pp_ifdef('chromeos')">
 @font-face {
   font-family: 'Open Sans';
   font-style: normal;
   font-weight: 400;
   src: local('Open Sans'), local('OpenSans'),
       url('chrome://resources/fonts/open_sans.woff') format('woff');
 }
 </if>