Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 9605020: Add install script for ant/java for Android and rename sdk install script. (Closed)

Created:
8 years, 9 months ago by navabi
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add install script for ant/java for Android and rename sdk install script. As we upstream Java source code, the upstream bots and developers need to hava java and ant. Ant is used to build the java source code. Installing ant/java requires sudo privileges which installation of sdk/ndk does not require. The patch moves the install script for sdk/ndk to install-build-deps-android-sdk.sh. The new install script for ant/java is called install-ubild-deps-android.sh and will prompt the user for sudo password. BUG=http://code.google.com/p/chromium/issues/detail?id=117023 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125297

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add install script for ant/java for Android and rename sdk install script. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -130 lines) Patch
M build/android/buildbot_functions.sh View 1 1 chunk +2 lines, -2 lines 0 comments Download
M build/android/envsetup.sh View 1 2 chunks +2 lines, -2 lines 0 comments Download
M build/install-build-deps-android.sh View 1 2 chunks +41 lines, -127 lines 0 comments Download
A + build/install-build-deps-android-sdk.sh View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
navabi
Couple things: - Need to test this on a machine that doesn't have java/ant to ...
8 years, 9 months ago (2012-03-06 19:53:49 UTC) #1
Yaron
On 2012/03/06 19:53:49, navabi wrote: > Couple things: > > - Need to test this ...
8 years, 9 months ago (2012-03-06 20:27:04 UTC) #2
John Grabowski
Don't forget to update buildbot_functions.sh which should reference the -sdk.sh script https://chromiumcodereview.appspot.com/9605020/diff/1/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): ...
8 years, 9 months ago (2012-03-06 21:05:42 UTC) #3
navabi
thanks yaron and jrg. https://chromiumcodereview.appspot.com/9605020/diff/1/build/install-build-deps-android.sh File build/install-build-deps-android.sh (right): https://chromiumcodereview.appspot.com/9605020/diff/1/build/install-build-deps-android.sh#newcode75 build/install-build-deps-android.sh:75: echo "install-build-deps-android.sh complete." On 2012/03/06 ...
8 years, 9 months ago (2012-03-06 23:41:01 UTC) #4
Yaron
lgtm
8 years, 9 months ago (2012-03-06 23:48:03 UTC) #5
John Grabowski
LGTM Be sure to update public build instructions; e.g. http://code.google.com/p/chromium/wiki/AndroidBuildInstructions
8 years, 9 months ago (2012-03-07 00:26:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/9605020/5001
8 years, 9 months ago (2012-03-07 00:37:43 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-07 02:22:19 UTC) #8
Change committed as 125297

Powered by Google App Engine
This is Rietveld 408576698