Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 9602029: Show applications page in aura compact mode. (Closed)

Created:
8 years, 9 months ago by flackr
Modified:
8 years, 9 months ago
Reviewers:
Dan Beam, Evan Stade
CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, estade+watch_chromium.org, xiyuan
Visibility:
Public.

Description

Show applications page in aura compact mode. BUG=116852 TEST=Launch chromeos aura in compact mode and observe that you can access applications on the new tab page. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125053

Patch Set 1 #

Total comments: 2

Patch Set 2 : Improve comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/ui/webui/ntp/new_tab_ui.cc View 1 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
flackr
PTAL, thanks.
8 years, 9 months ago (2012-03-05 22:05:57 UTC) #1
Evan Stade
lgtm http://codereview.chromium.org/9602029/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc File chrome/browser/ui/webui/ntp/new_tab_ui.cc (right): http://codereview.chromium.org/9602029/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc#newcode300 chrome/browser/ui/webui/ntp/new_tab_ui.cc:300: // Ash shows apps in app list thus ...
8 years, 9 months ago (2012-03-05 22:17:33 UTC) #2
flackr
Thanks! http://codereview.chromium.org/9602029/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc File chrome/browser/ui/webui/ntp/new_tab_ui.cc (right): http://codereview.chromium.org/9602029/diff/1/chrome/browser/ui/webui/ntp/new_tab_ui.cc#newcode300 chrome/browser/ui/webui/ntp/new_tab_ui.cc:300: // Ash shows apps in app list thus ...
8 years, 9 months ago (2012-03-05 22:56:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/flackr@chromium.org/9602029/9001
8 years, 9 months ago (2012-03-05 23:02:53 UTC) #4
xiyuan
Thank you for fixing this.
8 years, 9 months ago (2012-03-05 23:17:00 UTC) #5
commit-bot: I haz the power
Change committed as 125053
8 years, 9 months ago (2012-03-06 00:54:18 UTC) #6
Dan Beam
8 years, 9 months ago (2012-03-06 01:23:32 UTC) #7
This was reverted as it was breaking WebUITest.WebUIToStandard on Linux
ChromiumOS Tester (1), btw.

Powered by Google App Engine
This is Rietveld 408576698