Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: net/base/transport_security_state.cc

Issue 9602009: net: don't set HSTS for chart.apis.google.com (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/base/transport_security_state_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/transport_security_state.cc
diff --git a/net/base/transport_security_state.cc b/net/base/transport_security_state.cc
index 2129f4896fac3698aa644fd656330345eea2dc17..d5b94730a1a3562a5a43d366271254a98b515f4e 100644
--- a/net/base/transport_security_state.cc
+++ b/net/base/transport_security_state.cc
@@ -1331,6 +1331,12 @@ static const struct HSTSPreload kPreloadedSTS[] = {
DOMAIN_GOOGLE_COM },
{17, true, "\004apis\006google\003com", true, kGooglePins,
DOMAIN_GOOGLE_COM },
+ // chart.apis.google.com is *not* HSTS because the certificate doesn't match
+ // and there are lots of links out there that still use the name. The correct
+ // hostname for this is chart.googleapis.com.
+ {23, true, "\005chart\004apis\006google\003com", false, kGooglePins,
+ DOMAIN_GOOGLE_COM},
+
// Other Google-related domains that must use an acceptable certificate
// iff using SSL.
{11, true, "\005ytimg\003com", false, kGooglePins,
« no previous file with comments | « no previous file | net/base/transport_security_state_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698