Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 9602007: GTK: Move TranslateInfoBarBase::BuildOptionsMenuButton to InfoBarGtk::CreateMenuButton (Closed)

Created:
8 years, 9 months ago by Jeremy Mao
Modified:
8 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

GTK: Move TranslateInfoBarBase::BuildOptionsMenuButton to InfoBarGtk::CreateMenuButton BUG=NONE TEST=NONE Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125090

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix Evan's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -26 lines) Patch
M AUTHORS View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_gtk.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/infobar_gtk.cc View 1 1 chunk +20 lines, -0 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/gtk/infobars/translate_infobar_base_gtk.cc View 2 chunks +2 lines, -22 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jeremy Mao
Hi Evan, could you please take a look at this when you are free? Thanks ...
8 years, 9 months ago (2012-03-05 09:22:01 UTC) #1
Evan Stade
lgtm with nits http://codereview.chromium.org/9602007/diff/1/chrome/browser/ui/gtk/infobars/infobar_gtk.cc File chrome/browser/ui/gtk/infobars/infobar_gtk.cc (right): http://codereview.chromium.org/9602007/diff/1/chrome/browser/ui/gtk/infobars/infobar_gtk.cc#newcode133 chrome/browser/ui/gtk/infobars/infobar_gtk.cc:133: // TODO(jeremy): This is a temporary ...
8 years, 9 months ago (2012-03-05 22:13:51 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yujie.mao@intel.com/9602007/4002
8 years, 9 months ago (2012-03-06 01:15:25 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-06 03:17:10 UTC) #4
Change committed as 125090

Powered by Google App Engine
This is Rietveld 408576698