Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(727)

Issue 9602001: Reinitialize the cookie database if the meta table gets corrupted. (Closed)

Created:
8 years, 9 months ago by erikwright (departed)
Modified:
8 years, 9 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, erikwright (departed), wtc, Randy Smith (Not in Mondays), darin-cc_chromium.org, rkn
Visibility:
Public.

Description

Reinitialize the cookie database if the meta table gets corrupted. This has been shown to occur in the wild. At the moment users in this situation will simply get a failure to load or persist cookies (though cookies will work within the current session). After this change, users will see their Cookie database wiped out and reinitialized, but loading and persisting should work going forward. A histogram tracks how often this scenario is detected - it should probably spike as this is rolled out to new channels and then taper off (hopefully approaching 0). This is a minimal version with the hopes of being eligible for patching into M18. The preferred long-term version is here: http://codereview.chromium.org/9567022/ TBR=shess BUG=111376 TEST=unit_tests --gtest_filter=SQLitePersistentCookieStoreTest.TestInvalidMetaTableRecovery Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124899

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -4 lines) Patch
M chrome/browser/net/sqlite_persistent_cookie_store.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M chrome/browser/net/sqlite_persistent_cookie_store_unittest.cc View 2 chunks +45 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/erikwright@chromium.org/9602001/1
8 years, 9 months ago (2012-03-04 12:31:44 UTC) #1
commit-bot: I haz the power
8 years, 9 months ago (2012-03-04 15:57:26 UTC) #2
Change committed as 124899

Powered by Google App Engine
This is Rietveld 408576698