Add Password Autofill Manager to New Autofill

chrome/common/autofill_messages.h

Index: chrome/common/autofill_messages.h
diff --git a/chrome/common/autofill_messages.h b/chrome/common/autofill_messages.h
index b915ed2c1f9445c85fc9548d0c541a4538662708..68acf42e773db31f20bd2a339ff349fb38a44985 100644
--- a/chrome/common/autofill_messages.h
+++ b/chrome/common/autofill_messages.h
@@ -82,9 +82,11 @@ IPC_MESSAGE_ROUTED2(AutofillMsg_FormDataFilled,
                     webkit::forms::FormData /* form data */)
 
 // Fill a password form and prepare field autocomplete for multiple
-// matching logins.
-IPC_MESSAGE_ROUTED1(AutofillMsg_FillPasswordForm,
-                    webkit::forms::PasswordFormFillData)
+// matching logins. Lets the renderer know if it should disable the popup
+// because the browser process will own the popup UI.
+IPC_MESSAGE_ROUTED2(AutofillMsg_FillPasswordForm,
+                    webkit::forms::PasswordFormFillData, /* the fill form data*/
+                    bool /* disable popup */ )
 
 // Send the heuristic and server field type predictions to the renderer.
 IPC_MESSAGE_ROUTED1(
@@ -116,6 +118,10 @@ IPC_MESSAGE_ROUTED1(AutofillMsg_SetNodeText,
 IPC_MESSAGE_ROUTED1(AutofillMsg_GeneratedPasswordAccepted,
                     string16 /* generated_password */)
 
+// Tells the renderer that the password field has accept the suggestion.
+IPC_MESSAGE_ROUTED1(AutofillMsg_AcceptPasswordAutofillSuggestion,
+                    string16)

[Ilya Sherman, 2012/04/02 22:07:29]

nit: Please add a quick comment to describe the string16 parameter

[csharp, 2012/04/03 12:25:55]

Done.

+
 // Autofill messages sent from the renderer to the browser.
 
 // Notification that forms have been seen that are candidates for
@@ -187,8 +193,21 @@ IPC_MESSAGE_ROUTED0(AutofillHostMsg_DidEndTextFieldEditing)
 // Instructs the browser to hide the Autofill popup.
 IPC_MESSAGE_ROUTED0(AutofillHostMsg_HideAutofillPopup)
 

[Ilya Sherman, 2012/04/02 22:07:29]

nit: No need for this extra blank line (line 195)

[csharp, 2012/04/03 12:25:55]

Done.

+
 // Instructs the browser to show the password generation bubble at the
 // specified location. This location should be specified in the renderers
 // coordinate system.
 IPC_MESSAGE_ROUTED1(AutofillHostMsg_ShowPasswordGenerationPopup,
                     gfx::Rect /* source location */)
+
+// Instruct the browser that a password mapping has been found for a field.
+IPC_MESSAGE_ROUTED2(AutofillHostMsg_AddPasswordFormMapping,
+                    webkit::forms::FormField, /* the user name field */
+                    webkit::forms::PasswordFormFillData /*the form fill data */)

[Ilya Sherman, 2012/04/02 22:07:29]

nit: There should be a space between "/*" and "the" in the comment.  Also, "form
fill data" strikes me as really vague -- is there a concise way to describe what
that data actually consists of?  (If not, it's fine to leave the vague comment
-- concision is probably more important here.)

[csharp, 2012/04/03 12:25:55]

Changed the text to "password pairing", still a bit vague but I think it gives a
better ideas of what it represents.

+
+// Instruct the browser to show a popup with the following suggestions from the
+// password manager.
+IPC_MESSAGE_ROUTED3(AutofillHostMsg_ShowPasswordSuggestions,
+                    webkit::forms::FormField /* the form field */,
+                    gfx::Rect /* input field bounds, window-relative */,
+                    std::vector<string16> /* suggestions */)