Add Password Autofill Manager to New Autofill

chrome/browser/autofill/password_autofill_manager.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/autofill/password_autofill_manager.h"
+#include "chrome/common/autofill_messages.h"
+#include "content/public/browser/render_view_host.h"
+#include "ui/base/keycodes/keyboard_codes.h"
+
+////////////////////////////////////////////////////////////////////////////////
+// PasswordAutofillManager, public:
+
+PasswordAutofillManager::PasswordAutofillManager(
+    content::RenderViewHost* render_view_host)
+    : render_view_host_(render_view_host) {
+}
+
+PasswordAutofillManager::~PasswordAutofillManager() {
+}
+
+bool PasswordAutofillManager::WouldHandleKeyDown(
+    const webkit::forms::FormField& field) {
+  LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(field);
+  if (iter == login_to_password_info_.end())
+    return false;
+
+  return true;

[Ilya Sherman, 2012/03/15 18:27:41]

nit: You can combine lines 24-27 as """return iter !=
login_to_password_info_.end();"""

[csharp, 2012/03/16 20:21:12]

Done.

+}
+
+bool PasswordAutofillManager::DidAcceptAutofillSuggestion(
+    const webkit::forms::FormField& field,
+    const string16& value) {
+  webkit::forms::FormField input;
+  webkit::forms::PasswordFormFillData password;
+  if (!FindLoginInfo(field, &input, &password))
+    return false;
+
+  if (WillFillUserNameAndPassword(input, password)) {
+    if (render_view_host_) {
+      render_view_host_->Send(new AutofillMsg_PasswordAcceptAutofillSuggestion(
+          render_view_host_->GetRoutingID(),
+          value));
+    }
+    return true;
+  }
+
+  return false;
+}
+
+bool PasswordAutofillManager::DidSelectAutofillSuggestion(
+    const webkit::forms::FormField& field) {
+  webkit::forms::FormField input;
+  webkit::forms::PasswordFormFillData password;
+  return FindLoginInfo(field, &input, &password);
+}
+
+bool PasswordAutofillManager::DidClearAutofillSelection(
+    const webkit::forms::FormField& field) {
+  webkit::forms::FormField input;
+  webkit::forms::PasswordFormFillData password;
+  return FindLoginInfo(field, &input, &password);
+}
+
+void PasswordAutofillManager::AddPasswordFormMapping(
+    const webkit::forms::FormField& username_element,
+    const webkit::forms::PasswordFormFillData& password) {
+  login_to_password_info_[username_element] = password;
+}
+
+void PasswordAutofillManager::Reset() {
+  login_to_password_info_.clear();
+}
+
+////////////////////////////////////////////////////////////////////////////////
+// PasswordAutofillManager, private:
+
+bool PasswordAutofillManager::WillFillUserNameAndPassword(
+    const webkit::forms::FormField& username_element,
+    const webkit::forms::PasswordFormFillData& fill_data) {
+  string16 current_username = username_element.value;

[Ilya Sherman, 2012/03/15 18:27:41]

Hmm, is this always going to be the empty string, since the username_element is
cached?  Should this be comparing to the value of the |field| passed into
DidAcceptAutofillSuggestion() instead?

[csharp, 2012/03/16 20:21:12]

It is. I failed to copy over an assignment statement that happened in the
renderer. Fixed

+
+  // Look for any suitable matches to current field text.
+  if (fill_data.basic_data.fields[0].value == current_username) {

[Ilya Sherman, 2012/03/15 18:27:41]

Why is this a full string equality check, rather than a prefix comparison?  If
I've saved "isherman/password1" as a login pair, type "ish", and select the
"isherman" suggestion in the dropdown, shouldn't that cause both the username
and the password to be filled?

[csharp, 2012/03/16 20:21:12]

If you've selected isherman then current_username will be isherman, the selected
value, so we only want full matches otherwise this might want to use the
password for isherman1.

[Ilya Sherman, 2012/03/20 00:58:55]

What happens if I type "ish" and click on the suggestion?  Is that impossible
for some reason?  Even if the renderer very consistently autocompletes, is the
popup dismissed when I hit backspace?

[Ilya Sherman, 2012/03/22 01:20:06]

Bump.

[csharp, 2012/03/29 16:28:17]

current_username will be equal to what you selected from the popup box, not what
you've typed in the box so it will always have a valid full match.

The popup is not dismissed after hitting backspace (same as current behaviour)
and it will correctly fill in the password field as well if it is selected after
hitting delete.

+    return true;
+  } else {
+    // Scan additional logins for a match.
+    webkit::forms::PasswordFormFillData::LoginCollection::const_iterator iter;
+    for (iter = fill_data.additional_logins.begin();
+         iter != fill_data.additional_logins.end(); ++iter) {
+      if (iter->first == current_username)
+        return true;
+    }
+  }
+
+  return false;
+}
+
+bool PasswordAutofillManager::FindLoginInfo(
+    const webkit::forms::FormField& field,
+    webkit::forms::FormField* found_input,
+    webkit::forms::PasswordFormFillData* found_password) {
+  LoginToPasswordInfoMap::iterator iter = login_to_password_info_.find(field);
+  if (iter == login_to_password_info_.end())
+    return false;
+
+  *found_input = field;
+  *found_password = iter->second;
+  return true;
+}