Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 9600031: Move xvfb. Add llvmpipe.so. (Closed)

Created:
8 years, 9 months ago by Peter Mayo
Modified:
3 years, 11 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move xvfb. Add llvmpipe.so. Move xvfb into third_party. Move the executables into separate subdirs, to match the libraries. Add a software rasterizer driver for more GPU like testing. Update the Mesa rendering support to where the software pipeline works. Note: the Xvfb binaries are the old ones copied. I only tested the new 64 bit one a little. BUG=113583 TEST=Scripts work, and generate output that passes GPU tests manually. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=125014

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, --1 lines) Patch
A + third_party/xvfb/32bit/Xvfb.32bit View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/64bit/Xvfb.64bit View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/xvfb/64bit/llvmpipe.so View 1 Binary file 0 comments Download
A + third_party/xvfb/COPYING/dri2proto-2.3.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/COPYING/libXfont-1.4.3.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/COPYING/libXmu-1.0.5.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/COPYING/libXmu-libXmu-1.0.5.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/COPYING/libxkbfile-1.0.7.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/COPYING/util-macros-1.11.0.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/COPYING/xcb-proto-1.6.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/COPYING/xorg-server-1.9.3.901.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/COPYING/xproto-7.0.20.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/LICENSE.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/README.chromium View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/README.google View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/xvfb/building/fetch-source View 1 2 chunks +5 lines, -4 lines 0 comments Download
A + third_party/xvfb/building/install-prereq View 2 chunks +7 lines, -1 line 0 comments Download
A + third_party/xvfb/building/then-build View 1 2 chunks +14 lines, -8 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Peter Mayo
This seems like a good way to pull one of the pieces that we used ...
8 years, 9 months ago (2012-03-05 20:46:39 UTC) #1
cmp
lgtm
8 years, 9 months ago (2012-03-05 21:03:20 UTC) #2
Peter Mayo
http://codereview.chromium.org/9600031/diff/1038/third_party/xvfb/building/then-build File third_party/xvfb/building/then-build (right): http://codereview.chromium.org/9600031/diff/1038/third_party/xvfb/building/then-build#newcode48 third_party/xvfb/building/then-build:48: [ -d lib ] || mkdir lib perhaps 'mkdir ...
8 years, 9 months ago (2012-03-05 21:11:51 UTC) #3
Marc-Antoine Ruel (Google)
8 years, 9 months ago (2012-03-05 21:21:48 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698