Move the pepper flash to the top of the flash plugin list, if the client is within the enable-by-de…

Move the pepper flash to the top of the flash plugin list, if the client is within the enable-by-default field trial group.

BUG=None
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125099

[yzshen1, 2012-03-05 19:06:29]

Hi, Carlos.

Please take a look. Thanks!

[cpu_(ooo_6.6-7.5), 2012-03-05 21:11:46]

lgtm

please add bauerb@ to the review. If you _really_ need to check in this today go
ahead but if it is not super urgent please wait for his feedback.

[yzshen1, 2012-03-05 22:16:31]

Hi, Bernhard.

Would you please take a look at this CL?

Since this CL fixes an issue in the Canary field trial, I wish I could get it
landed today. Thanks a lot!

[Bernhard Bauer, 2012-03-05 22:23:09]

LGTM.

http://codereview.chromium.org/9600029/diff/1/chrome/browser/component_update...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

http://codereview.chromium.org/9600029/diff/1/chrome/browser/component_update...
chrome/browser/component_updater/pepper_flash_component_installer.cc:186:
plugin_info.ToWebPluginInfo(), enable_by_default);
Could you move this into a separate variable |add_to_front| or something so that
the meaning of the parameter is clear?

[yzshen1, 2012-03-05 22:53:37]

Thanks, Carlos and Bernhard!

http://codereview.chromium.org/9600029/diff/1/chrome/browser/component_update...
File chrome/browser/component_updater/pepper_flash_component_installer.cc
(right):

http://codereview.chromium.org/9600029/diff/1/chrome/browser/component_update...
chrome/browser/component_updater/pepper_flash_component_installer.cc:186:
plugin_info.ToWebPluginInfo(), enable_by_default);
On 2012/03/05 22:23:09, Bernhard Bauer wrote:
> Could you move this into a separate variable |add_to_front| or something so
that
> the meaning of the parameter is clear?

Done.

[commit-bot: I haz the power, 2012-03-06 01:53:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yzshen@chromium.org/9600029/7001

[commit-bot: I haz the power, 2012-03-06 03:51:55]

Change committed as 125099