Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 9600010: Add --ignore to gclient recurse (Closed)

Created:
8 years, 9 months ago by M-A Ruel
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Dirk Pranke, M-A Ruel, davidbarr
Visibility:
Public.

Description

Add --ignore to gclient recurse This permits running git grep over the dependencies. With --ignore, gclient recurse continues even if nothing is found in a dependency. Without this flag, git grep returns 1 when nothing is found, causing gclient to stop processing the remaining dependencies. TBR=nsylvain@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124914

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M gclient.py View 2 chunks +8 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
M-A Ruel
8 years, 9 months ago (2012-03-05 00:36:10 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/9600010/1
8 years, 9 months ago (2012-03-05 00:37:10 UTC) #2
commit-bot: I haz the power
Change committed as 124914
8 years, 9 months ago (2012-03-05 00:43:08 UTC) #3
nsylvain
8 years, 9 months ago (2012-03-05 20:06:16 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698