Stop sending the testfilter= flag to the try server and process it locally.

Stop sending the testfilter= flag to the try server and process it locally.

The previous behavior would cause inproper parsing;
- the bot=bot1 flag would add 'bot1': ['defaulttests'] to the dictionary.
- the testfilter=test1 flag would append 'test1' to the list, causing the value
  to look like 'bot1': ['defaulttests', 'test1'].

I think on the long run the best is to keep --testfilter as a user interface but
not on the try server. This effectively stops sending testfilter=foo to the
server.

Add unit test to verify it's working properly. Refactor a bit to make unit
testing simpler.

R=petermayo@chromium.org
BUG=
TEST=

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125405

[M-A Ruel, 2012-03-07 01:21:36]

Deflecting to Peter.

[Peter Mayo, 2012-03-07 15:20:28]

lgtm

[Peter Mayo, 2012-03-07 15:53:45]

https://chromiumcodereview.appspot.com/9599012/diff/1/tests/trychange_unittes...
File tests/trychange_unittest.py (right):

https://chromiumcodereview.appspot.com/9599012/diff/1/tests/trychange_unittes...
tests/trychange_unittest.py:80: ('bot', 'bot2:test1,test2'),
Eventually flagging this as ambiguous might be good:

some people may expect this set of arguments to mean
bot1:test1  bot2:test2

[M-A Ruel, 2012-03-07 17:52:56]

https://chromiumcodereview.appspot.com/9599012/diff/1/tests/trychange_unittes...
File tests/trychange_unittest.py (right):

https://chromiumcodereview.appspot.com/9599012/diff/1/tests/trychange_unittes...
tests/trychange_unittest.py:80: ('bot', 'bot2:test1,test2'),
On 2012/03/07 15:53:46, Peter Mayo wrote:
> Eventually flagging this as ambiguous might be good:
> 
> some people may expect this set of arguments to mean
> bot1:test1  bot2:test2

Good question. Not sure though about processing the flags in order.

[commit-bot: I haz the power, 2012-03-07 17:53:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9599012/1

[commit-bot: I haz the power, 2012-03-07 17:59:40]

Presubmit check for 9599012-1 failed and returned exit status 1.

warning: code.google.com certificate with fingerprint
3e:ee:95:02:aa:37:61:1e:8c:3e:5d:85:6c:e7:76:13:9d:4e:3c:75 not verified (check
hostfingerprints or web.cacerts config setting)
Running presubmit commit checks ...
Checking out rietveld...
Running push-basic.sh
Running save-description-on-failure.sh
Running basic.sh
Running upload-stale.sh
Running upload-local-tracking-branch.sh
Running patch.sh
Running submit-from-new-dir.sh
Running post-dcommit-hook-test.sh
Running hooks.sh
Running abandon.sh
Running upstream.sh

** Presubmit Messages **
You should install python 2.5 and run ln -s $(which python2.5) python.
A great place to put this symlink is in depot_tools.
Otherwise, you break depot_tools on python 2.5, you get to keep the pieces.

** Presubmit ERRORS **
tests/trychange_unittest.py failed!
Command tests/trychange_unittest.py returned non-zero exit status 1 in
/mnt/data/b/commit-queue/workdir/tools/depot_tools
....F..
======================================================================
FAIL: test_flags (__main__.TryChangeSimpleTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "tests/trychange_unittest.py", line 82, in test_flags
    values)
AssertionError: [('user', 'maruel'), ('name', None), ('email',
'maruel@chromium.org'), ('bot', 'bot1:test1,test2'), ('bot',
'bot2:test1,test2')] != [('user', 'chrome-bot'), ('name', None), ('bot',
'bot1:test1,test2'), ('bot', 'bot2:test1,test2')]

----------------------------------------------------------------------
Ran 7 tests in 0.012s

FAILED (failures=1)


Presubmit checks took 388.0s to calculate.

[commit-bot: I haz the power, 2012-03-07 18:04:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/maruel@chromium.org/9599012/4003

[commit-bot: I haz the power, 2012-03-07 18:11:12]

Change committed as 125405