Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 9599010: JNI Bindings on Chrome for Android: unfork. (Closed)

Created:
8 years, 9 months ago by bulach
Modified:
8 years, 9 months ago
Reviewers:
Mark Mentovai, joth
CC:
chromium-reviews, brettw-cc_chromium.org
Visibility:
Public.

Description

JNI Bindings on Chrome for Android: unfork. A few more changes as required by: http://codereview.chromium.org/9466024/ Also, rather than just running the python-based tests (jni_generator_py_tests), we'll now run the full suite (jni_generator_tests) instead. BUG=none TEST=jni_generator_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125604

Patch Set 1 #

Total comments: 2

Patch Set 2 : Mark's comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -4 lines) Patch
M base/android/jni_android.h View 1 4 chunks +18 lines, -0 lines 0 comments Download
M base/android/jni_android.cc View 3 chunks +23 lines, -3 lines 0 comments Download
M base/base.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
bulach
8 years, 9 months ago (2012-03-05 13:39:26 UTC) #1
joth
lgtm
8 years, 9 months ago (2012-03-05 17:21:32 UTC) #2
bulach
+mark, for base.gyp
8 years, 9 months ago (2012-03-06 10:28:10 UTC) #3
Mark Mentovai
http://codereview.chromium.org/9599010/diff/1/base/android/jni_android.h File base/android/jni_android.h (right): http://codereview.chromium.org/9599010/diff/1/base/android/jni_android.h#newcode15 base/android/jni_android.h:15: #define JNI_EXPORT __attribute__ ((visibility("default"))) Unused?
8 years, 9 months ago (2012-03-06 22:02:29 UTC) #4
bulach
thanks mark! comment addressed, another look please? http://codereview.chromium.org/9599010/diff/1/base/android/jni_android.h File base/android/jni_android.h (right): http://codereview.chromium.org/9599010/diff/1/base/android/jni_android.h#newcode15 base/android/jni_android.h:15: #define JNI_EXPORT ...
8 years, 9 months ago (2012-03-07 11:04:23 UTC) #5
Mark Mentovai
LGTM
8 years, 9 months ago (2012-03-07 17:11:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bulach@chromium.org/9599010/4002
8 years, 9 months ago (2012-03-08 08:54:20 UTC) #7
commit-bot: I haz the power
8 years, 9 months ago (2012-03-08 12:39:16 UTC) #8
Change committed as 125604

Powered by Google App Engine
This is Rietveld 408576698