Issue 9599009: Fix infinite refresh of device policy when the TPM gets out of sync with the stateful partition.

Issue 9599009: Fix infinite refresh of device policy when the TPM gets out of sync with the stateful partition. (Closed)

Created:
8 years, 9 months ago by Joao da Silva

Modified:
8 years, 9 months ago

Reviewers:
pastarmovj

CC:
chromium-reviews

Base URL:
http://git.chromium.org/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

Fix infinite refresh of device policy when the TPM gets out of sync with the stateful partition. BUG=chromium-os:27251 TEST=Enroll a device. Flip the dev switch back and forth. The device should stop issuing device policy fetches every second. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124966

Patch Set 1 #

Patch Set 2 : Added unit test #

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -29 lines)			Patch
M	chrome/browser/policy/cloud_policy_cache_base.h	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_controller.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_controller_unittest.cc	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
M	chrome/browser/policy/cloud_policy_provider_unittest.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	chrome/browser/policy/device_policy_cache.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/device_policy_cache.cc	View		5 chunks	+5 lines, -4 lines	0 comments	Download
M	chrome/browser/policy/device_policy_cache_unittest.cc	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/policy/user_policy_cache.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/user_policy_cache.cc	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/policy/user_policy_cache_unittest.cc	View		10 chunks	+13 lines, -12 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

Please review. I'll only land if the bots also like it.

8 years, 9 months ago (2012-03-05 10:27:34 UTC) #1

Joao da Silva

PTAL. Added a test that fails before this fix, and that should catch the same ...

8 years, 9 months ago (2012-03-05 14:28:51 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/9599009/5001

8 years, 9 months ago (2012-03-05 16:29:16 UTC) #4

Change committed as 124966

Expand Messages | Collapse Messages