Issue 9596003: [WebUI] Make drag'n'drop future proof.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9596003: [WebUI] Make drag'n'drop future proof. (Closed)

Created:
8 years, 9 months ago by Dan Beam

Modified:
8 years, 9 months ago

Reviewers:
eroman, Evan Stade

CC:
chromium-reviews, dbeam+watch-ntp_chromium.org, tfarina, eroman, arv (Not doing code reviews), estade+watch_chromium.org, mmenke

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

[WebUI] Make drag'n'drop future proof. TEST=Drag and drop from external sources works on NTP and net-internals. BUG=115433 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125109

Created: 8 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	chrome/browser/resources/net_internals/import_view.js	View	1	2 chunks	+9 lines, -2 lines	0 comments	Download
	M	chrome/browser/resources/ntp4/apps_page.js	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Total messages: 7 (0 generated)

Dan Beam

estade: chrome/browser/resources/ntp4 eroman: chrome/browser/resources/net_internals

8 years, 9 months ago (2012-03-05 22:45:51 UTC) #2

eroman

LGTM. Can you add a comment explaining why we do this weirdness, perhaps linked to ...

8 years, 9 months ago (2012-03-06 00:27:26 UTC) #4

Dan Beam

On 2012/03/06 00:27:26, eroman wrote: > LGTM. > > Can you add a comment explaining ...

8 years, 9 months ago (2012-03-06 02:42:34 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dbeam@chromium.org/9596003/4001

8 years, 9 months ago (2012-03-06 02:42:44 UTC) #6

Change committed as 125109