[Web Intents] Inline installation of extensions in web intents picker.

chrome/browser/intents/web_intents_registry.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_INTENTS_WEB_INTENTS_REGISTRY_H_
 #define CHROME_BROWSER_INTENTS_WEB_INTENTS_REGISTRY_H_
 #pragma once
 
 #include "base/callback_forward.h"
 #include "base/hash_tables.h"
@@ skipping 59 matching lines @@
   // Requests all services. |consumer| must not be NULL
   QueryID GetAllIntentServices(Consumer* consumer);
 
   // Tests for the existence of the given |service|. Calls the
   // provided |callback| with true if it exists, false if it does not.
   // Checks for |service| equality with ==.
   QueryID IntentServiceExists(
       const webkit_glue::WebIntentServiceData& service,
       const base::Callback<void(bool)>& callback);
 
+  // Requests all extension services matching |action|, |mimetype| and
+  // |extension_id|.
+  // |mimetype| can contain wildcards, i.e. "image/*" or "*".
+  // |consumer| must not be NULL.
+  QueryID GetIntentServicesForExtensionFilter(const string16& action,
+                                              const string16& mimetype,
+                                              const std::string& extension_id,

[groby-ooo-7-16, 2012/03/15 23:39:25]

Please simply point to a canonical location for mimetype specs. I.e.

  // |mimetype| must conform to definition as outlined for
  // WebIntentsRegistry::GetIntentServices.

[binji, 2012/03/16 22:17:21]

Done.

+                                              Consumer* consumer);
+
   // Record the given default service entry.
   virtual void RegisterDefaultIntentService(
       const DefaultWebIntentService& default_service);
 
   // Delete the given default service entry. Deletes entries matching
   // the |action|, |type|, and |url_pattern| of |default_service|.
   virtual void UnregisterDefaultIntentService(
       const DefaultWebIntentService& default_service);
 
   // Requests the best default intent service for the given invocation
@@ skipping 25 matching lines @@
   // WebDataServiceConsumer implementation.
   virtual void OnWebDataServiceRequestDone(
       WebDataService::Handle h,
       const WDTypedResult* result) OVERRIDE;
 
   // Delegate for defaults requests from OnWebDataServiceRequestDone.
   virtual void OnWebDataServiceDefaultsRequestDone(
       WebDataService::Handle h,
       const WDTypedResult* result);
 
+  // Implementation of |GetIntentServicesForExtensionFilter|.

[groby-ooo-7-16, 2012/03/15 23:39:25]

Function names are not in ||

[binji, 2012/03/16 22:17:21]

Done.

+  void DoGetIntentServicesForExtensionFilter(scoped_ptr<IntentsQuery> query,
+                                             const std::string& extension_id);
+
   // Map for all in-flight web data requests/intent queries.
   QueryMap queries_;
 
   // Unique identifier for next intent query.
   QueryID next_query_id_;
 
   // Local reference to Web Data Service.
   scoped_refptr<WebDataService> wds_;
 
   // Local reference to the ExtensionService.
   // Shutdown/cleanup is handled by ProfileImpl. We are  guaranteed that any
   // ProfileKeyedService will be shut down before data on ProfileImpl is
   // destroyed (i.e. |extension_service_|), so |extension_service_| is valid
   // for the lifetime of the WebIntentsRegistry object.
   ExtensionServiceInterface* extension_service_;
 
   DISALLOW_COPY_AND_ASSIGN(WebIntentsRegistry);
 };
 
 #endif  // CHROME_BROWSER_INTENTS_WEB_INTENTS_REGISTRY_H_