Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5011)

Unified Diff: chrome/browser/extensions/extension_install_ui.cc

Issue 9595025: Don't use NTP for app install if NTP does not show apps page. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_install_ui.cc
diff --git a/chrome/browser/extensions/extension_install_ui.cc b/chrome/browser/extensions/extension_install_ui.cc
index 8052ecb36bf6168a7d356a0ed292156fc8d0ed7b..839db07025d2b4f4cef6a6042511bbec15854adb 100644
--- a/chrome/browser/extensions/extension_install_ui.cc
+++ b/chrome/browser/extensions/extension_install_ui.cc
@@ -28,6 +28,7 @@
#include "chrome/browser/ui/browser_navigator.h"
#include "chrome/browser/ui/browser_window.h"
#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
+#include "chrome/browser/ui/webui/ntp/new_tab_ui.h"
#include "chrome/common/chrome_notification_types.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension.h"
@@ -298,7 +299,9 @@ void ExtensionInstallUI::OnInstallSuccess(const Extension* extension,
cmdline->HasSwitch(switches::kAppsNewInstallBubble));
#endif
- if (extension->is_app() && !use_bubble_for_apps) {
+ if (extension->is_app() &&
+ !use_bubble_for_apps &&
+ NewTabUI::ShouldShowAppsPage()) {
ExtensionInstallUI::OpenAppInstalledNTP(browser, extension->id());
return;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698