Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(279)

Issue 9595025: Don't use NTP for app install if NTP does not show apps page. (Closed)

Created:
8 years, 9 months ago by xiyuan
Modified:
8 years, 9 months ago
CC:
chromium-reviews, Aaron Boodman, mihaip+watch_chromium.org, Evan Stade
Visibility:
Public.

Description

Don't use NTP for app install if NTP does not show apps page. BUG=116318 TEST=Verify that extension install bubble shows up instead of NTP after extension install. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=125081

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M chrome/browser/extensions/extension_install_ui.cc View 2 chunks +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
xiyuan
8 years, 9 months ago (2012-03-05 17:56:50 UTC) #1
asargent_no_longer_on_chrome
lgtm
8 years, 9 months ago (2012-03-05 22:37:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xiyuan@chromium.org/9595025/1
8 years, 9 months ago (2012-03-05 23:07:51 UTC) #3
commit-bot: I haz the power
8 years, 9 months ago (2012-03-06 02:48:59 UTC) #4
Change committed as 125081

Powered by Google App Engine
This is Rietveld 408576698