Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: chrome/browser/extensions/extension_updater.cc

Issue 9595001: Apps on NTP should be in order of installation (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_updater.cc
diff --git a/chrome/browser/extensions/extension_updater.cc b/chrome/browser/extensions/extension_updater.cc
index 04f5c293ec6bc4f073a4a08fd55bda94bdec6610..0d4ff6be3e63f45db6e66009f22f47f394eef287 100644
--- a/chrome/browser/extensions/extension_updater.cc
+++ b/chrome/browser/extensions/extension_updater.cc
@@ -1035,10 +1035,10 @@ void ExtensionUpdater::CheckNow() {
const PendingExtensionManager* pending_extension_manager =
service_->pending_extension_manager();
- std::set<std::string> pending_ids;
+ std::list<std::string> pending_ids;
pending_extension_manager->GetPendingIdsForUpdateCheck(&pending_ids);
- std::set<std::string>::const_iterator iter;
+ std::list<std::string>::const_iterator iter;
for (iter = pending_ids.begin(); iter != pending_ids.end(); ++iter) {
PendingExtensionInfo info;
bool found_id = pending_extension_manager->GetById(*iter, &info);
@@ -1060,7 +1060,7 @@ void ExtensionUpdater::CheckNow() {
// An extension might be overwritten by policy, and have its update url
// changed. Make sure existing extensions aren't fetched again, if a
// pending fetch for an extension with the same id already exists.
- if (!ContainsKey(pending_ids, (*iter)->id())) {
+ if (!pending_extension_manager->IsIdPending((*iter)->id())) {
fetches_builder.AddExtension(**iter);
}
}

Powered by Google App Engine
This is Rietveld 408576698