Apps on NTP should be in order of installation

chrome/browser/extensions/updater/extension_updater_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+#include <list>
 #include <map>
 #include <set>
 #include <vector>
 
 #include "base/compiler_specific.h"
 #include "base/file_util.h"
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
 #include "base/stl_util.h"
 #include "base/string_number_conversions.h"
@@ skipping 212 matching lines @@
 
 bool ShouldInstallThemesOnly(const Extension& extension) {
   return extension.is_theme();
 }
 
 bool ShouldAlwaysInstall(const Extension& extension) {
   return true;
 }
 
 // Loads some pending extension records into a pending extension manager.
+// Require that there are no pending extensions in the pending extension manager

[Aaron Boodman, 2012/05/11 19:23:55]

Put this comment above the assertion. Or just kill it entirely, the assertion
says the same thing.

+// prior to this function call.
 void SetupPendingExtensionManagerForTest(
     int count,
     const GURL& update_url,
     PendingExtensionManager* pending_extension_manager) {
-  for (int i = 1; i <= count; i++) {
+  ASSERT_EQ(0u, pending_extension_manager->pending_extension_list_.size());
+
+  for (int i = count; i >= 1; --i) {
     PendingExtensionInfo::ShouldAllowInstallPredicate should_allow_install =
         (i % 2 == 0) ? &ShouldInstallThemesOnly : &ShouldInstallExtensionsOnly;
     const bool kIsFromSync = true;
     const bool kInstallSilently = true;
     std::string id = GenerateId(base::StringPrintf("extension%i", i));
 
     pending_extension_manager->AddForTesting(
-        id,
-        PendingExtensionInfo(update_url,
+        PendingExtensionInfo(id,
+                             update_url,
                              Version(),
                              should_allow_install,
                              kIsFromSync,
                              kInstallSilently,
                              Extension::INTERNAL));
   }
+
+  // Check to see if the order in which the extensions were added is preserved.
+  std::list<std::string> pending_ids;
+  pending_extension_manager->GetPendingIdsForUpdateCheck(&pending_ids);
+  int i = count;
+  for (std::list<std::string>::const_iterator it = pending_ids.begin();

[Aaron Boodman, 2012/05/11 19:23:55]

This is fine, but not sure if it's really worth testing.

+       it != pending_ids.end(); ++it, --i) {
+    ASSERT_EQ(*it, base::StringPrintf("extension%i", i));
+  }
 }
 
 class ServiceForManifestTests : public MockService {
  public:
   ServiceForManifestTests() {}
 
   virtual ~ServiceForManifestTests() {}
 
   virtual const Extension* GetExtensionById(
       const std::string& id, bool include_disabled) const OVERRIDE {
@@ skipping 427 matching lines @@
     SetupPendingExtensionManagerForTest(3, GURL(), pending_extension_manager);
 
     TestingProfile profile;
     profile.CreateRequestContext();
     MockExtensionDownloaderDelegate delegate;
     ExtensionDownloader downloader(&delegate, profile.GetRequestContext());
 
     ManifestFetchData fetch_data(GURL("http://localhost/foo"));
     UpdateManifest::Results updates;
 
-    std::set<std::string> ids_for_update_check;
+    std::list<std::string> ids_for_update_check;
     pending_extension_manager->GetPendingIdsForUpdateCheck(
         &ids_for_update_check);
 
-    std::set<std::string>::const_iterator it;
+    std::list<std::string>::const_iterator it;
     for (it = ids_for_update_check.begin();
          it != ids_for_update_check.end(); ++it) {
       fetch_data.AddExtension(*it, "1.0.0.0",
                               &kNeverPingedData, kEmptyUpdateUrlData, "");
       AddParseResult(*it, "1.1", "http://localhost/e1_1.1.crx", &updates);
     }
 
     // The delegate will tell the downloader that all the extensions are
     // pending.
     EXPECT_CALL(delegate, IsExtensionPending(_)).WillRepeatedly(Return(true));
@@ skipping 141 matching lines @@
     ASSERT_TRUE(version.get());
     updater.downloader_->FetchUpdatedExtension(
         id, test_url, hash, version->GetString());
 
     if (pending) {
       const bool kIsFromSync = true;
       const bool kInstallSilently = true;
       PendingExtensionManager* pending_extension_manager =
           service->pending_extension_manager();
       pending_extension_manager->AddForTesting(
-          id,
-          PendingExtensionInfo(test_url, *version,
+          PendingExtensionInfo(id, test_url, *version,
                                &ShouldAlwaysInstall, kIsFromSync,
                                kInstallSilently,
                                Extension::INTERNAL));
     }
 
     // Call back the ExtensionUpdater with a 200 response and some test data
     FilePath extension_file_path(FILE_PATH_LITERAL("/whatever"));
     fetcher = factory.GetFetcherByID(ExtensionDownloader::kExtensionFetcherId);
     EXPECT_TRUE(fetcher != NULL && fetcher->delegate() != NULL);
     EXPECT_TRUE(fetcher->GetLoadFlags() == kExpectedLoadFlags);
@@ skipping 625 matching lines @@
 // -prodversionmin (shouldn't update if browser version too old)
 // -manifests & updates arriving out of order / interleaved
 // -malformed update url (empty, file://, has query, has a # fragment, etc.)
 // -An extension gets uninstalled while updates are in progress (so it doesn't
 //  "come back from the dead")
 // -An extension gets manually updated to v3 while we're downloading v2 (ie
 //  you don't get downgraded accidentally)
 // -An update manifest mentions multiple updates
 
 }  // namespace extensions