Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5933)

Unified Diff: chrome/test/functional/history.py

Issue 9594016: Fixed the history.HistoryTest.testOneHistoryTabPerWindow pyauto. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/history.py
diff --git a/chrome/test/functional/history.py b/chrome/test/functional/history.py
index 7608ae409cca4e1a5cf47868845c3c5aa4be64cf..1a870ad668ca17b95279d26fcc8ea7bcc7dae661 100755
--- a/chrome/test/functional/history.py
+++ b/chrome/test/functional/history.py
@@ -326,6 +326,12 @@ class HistoryTest(pyauto.PyUITest):
Also, make sure that existing history tab is activated.
"""
+ command_line = self.GetBrowserInfo()['properties']['command_line_string']
+ if '--disable-uber-page' in command_line.split():
+ history_url = 'chrome://history-frame/'
+ else:
+ history_url = 'chrome://chrome/history/'
+
# Invoke History.
self.RunCommand(pyauto.IDC_SHOW_HISTORY)
self.assertEqual('History', self.GetActiveTabTitle(),
@@ -338,12 +344,12 @@ class HistoryTest(pyauto.PyUITest):
# Verify there is only one history tab, and that it is activated.
tab0url = self.GetBrowserInfo()['windows'][0]['tabs'][0]['url']
self.assertEqual(
- 'chrome://history/', tab0url, msg='Tab 0: expected = %s, actual = %s.'
- % ('chrome://history/', tab0url))
+ history_url, tab0url, msg='Tab 0: expected = %s, actual = %s.'
+ % (history_url, tab0url))
tab1url = self.GetBrowserInfo()['windows'][0]['tabs'][1]['url']
self.assertNotEqual(
- 'chrome://history/', tab1url,
+ history_url, tab1url,
msg='Tab 1: History page not expected.')
self.assertEqual('History', self.GetActiveTabTitle(),
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698