Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1201)

Side by Side Diff: chrome/browser/ui/browser.cc

Issue 9590001: Launch panels as popup windows in Aura, and add separate launcher icon logic for panels. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Fix logic in SetAppImage, add comment. Created 8 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/browser.h" 5 #include "chrome/browser/ui/browser.h"
6 6
7 #if defined(OS_WIN) 7 #if defined(OS_WIN)
8 #include <windows.h> 8 #include <windows.h>
9 #include <shellapi.h> 9 #include <shellapi.h>
10 #endif // OS_WIN 10 #endif // OS_WIN
(...skipping 4585 matching lines...) Expand 10 before | Expand all | Expand 10 after
4596 void Browser::ShowFirstRunBubble() { 4596 void Browser::ShowFirstRunBubble() {
4597 window()->GetLocationBar()->ShowFirstRunBubble(); 4597 window()->GetLocationBar()->ShowFirstRunBubble();
4598 } 4598 }
4599 4599
4600 /////////////////////////////////////////////////////////////////////////////// 4600 ///////////////////////////////////////////////////////////////////////////////
4601 // Browser, protected: 4601 // Browser, protected:
4602 4602
4603 BrowserWindow* Browser::CreateBrowserWindow() { 4603 BrowserWindow* Browser::CreateBrowserWindow() {
4604 // TODO(yfriedman): remove OS_ANDROID clause when browser is excluded from 4604 // TODO(yfriedman): remove OS_ANDROID clause when browser is excluded from
4605 // Android build. 4605 // Android build.
4606 #if (!defined(OS_CHROMEOS) || defined(USE_AURA)) && !defined(OS_ANDROID) 4606 #if !defined(OS_ANDROID)
4607 if (is_type_panel()) 4607 bool create_panel = false;
4608 #if defined(USE_AURA)
4609 if (CommandLine::ForCurrentProcess()->HasSwitch(
4610 ash::switches::kAuraPanelManager))
4611 create_panel = is_type_panel();
4612 #elif !defined(OS_CHROMEOS)
4613 create_panel = is_type_panel();
4614 #endif
4615 if (create_panel)
4608 return PanelManager::GetInstance()->CreatePanel(this); 4616 return PanelManager::GetInstance()->CreatePanel(this);
4609 #endif 4617 #endif // OS_ANDROID
4610 4618
4611 return BrowserWindow::CreateBrowserWindow(this); 4619 return BrowserWindow::CreateBrowserWindow(this);
4612 } 4620 }
4613 4621
4614 4622
4615 /////////////////////////////////////////////////////////////////////////////// 4623 ///////////////////////////////////////////////////////////////////////////////
4616 // Browser, Command and state updating (private): 4624 // Browser, Command and state updating (private):
4617 4625
4618 void Browser::InitCommandState() { 4626 void Browser::InitCommandState() {
4619 // All browser commands whose state isn't set automagically some other way 4627 // All browser commands whose state isn't set automagically some other way
(...skipping 1007 matching lines...) Expand 10 before | Expand all | Expand 10 after
5627 ShowSingletonTabOverwritingNTP(params); 5635 ShowSingletonTabOverwritingNTP(params);
5628 } else { 5636 } else {
5629 LoginUIServiceFactory::GetForProfile( 5637 LoginUIServiceFactory::GetForProfile(
5630 profile()->GetOriginalProfile())->ShowLoginUI(); 5638 profile()->GetOriginalProfile())->ShowLoginUI();
5631 } 5639 }
5632 } 5640 }
5633 5641
5634 void Browser::ToggleSpeechInput() { 5642 void Browser::ToggleSpeechInput() {
5635 GetSelectedWebContents()->GetRenderViewHost()->ToggleSpeechInput(); 5643 GetSelectedWebContents()->GetRenderViewHost()->ToggleSpeechInput();
5636 } 5644 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698