Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5570)

Unified Diff: chrome/browser/download/download_file_picker.cc

Issue 9589003: Replace void* with int32 for passing download_id to SelectFileDialog::Listener. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix browser/unit tests Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/download/download_file_picker.h ('k') | content/browser/download/download_manager_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/download/download_file_picker.cc
===================================================================
--- chrome/browser/download/download_file_picker.cc (revision 124549)
+++ chrome/browser/download/download_file_picker.cc (working copy)
@@ -56,8 +56,9 @@
DownloadManager* download_manager,
WebContents* web_contents,
const FilePath& suggested_path,
- void* params)
+ int32 download_id)
: download_manager_(download_manager),
+ download_id_(download_id),
suggested_path_(suggested_path) {
DCHECK(download_manager_);
select_file_dialog_ = SelectFileDialog::Create(this);
@@ -76,7 +77,7 @@
string16(),
suggested_path,
&file_type_info, 0, FILE_PATH_LITERAL(""),
- web_contents, owning_window, params);
+ web_contents, owning_window, NULL);
}
DownloadFilePicker::~DownloadFilePicker() {
@@ -96,13 +97,13 @@
FilePickerResult result = ComparePaths(suggested_path_, path);
RecordFilePickerResult(download_manager_, result);
if (download_manager_)
- download_manager_->FileSelected(path, params);
+ download_manager_->FileSelected(path, download_id_);
delete this;
}
void DownloadFilePicker::FileSelectionCanceled(void* params) {
RecordFilePickerResult(download_manager_, FILE_PICKER_CANCEL);
if (download_manager_)
- download_manager_->FileSelectionCanceled(params);
+ download_manager_->FileSelectionCanceled(download_id_);
delete this;
}
« no previous file with comments | « chrome/browser/download/download_file_picker.h ('k') | content/browser/download/download_manager_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698